Bug 408979 - Using custom shortcut to go to next or previous image selects image instead
Summary: Using custom shortcut to go to next or previous image selects image instead
Status: ASSIGNED
Alias: None
Product: gwenview
Classification: Applications
Component: general (other bugs)
Version First Reported In: 17.12.3
Platform: openSUSE Linux
: NOR normal
Target Milestone: ---
Assignee: Gwenview Bugs
URL:
Keywords: junior-jobs
Depends on:
Blocks:
 
Reported: 2019-06-21 09:05 UTC by Nikitail
Modified: 2024-10-05 20:06 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nikitail 2019-06-21 09:05:38 UTC
Using Ctrl+key in shortcut to switch image selects the image you would switch to instead of just switching to it.

STEPS TO REPRODUCE
1. Set a shortcut that switches to next or previous image to a something that contains Ctrl key, for example set "Next" to "Ctrl-U" or "Ctrl-PgDown"
2. Open a folder containing many images
3. Press the shortcut you just set

OBSERVED RESULT
A split view with two images selected opens. Repeated presses will open more and more split views with new images

EXPECTED RESULT
Next image opens and takes all the space availible in the window (no splits)

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: openSUSE Leap 15.0
(available in About System)
KDE Plasma Version: 5.12.8
KDE Frameworks Version: 5.45.0
Qt Version: 5.9.4
Comment 1 Nate Graham 2019-06-22 09:41:20 UTC
Yep. Can confirm.
Comment 2 Patrick Silva 2020-02-12 16:29:59 UTC
Same thing with gwenview 19.12.2.

Operating System: Arch Linux 
KDE Plasma Version: 5.18.0
KDE Frameworks Version: 5.67.0
Qt Version: 5.14.1
Comment 3 Andrew Shark 2023-07-12 22:12:07 UTC
Still happening.

Operating System: Arch Linux 
KDE Plasma Version: 5.27.6
KDE Frameworks Version: 5.108.0
Qt Version: 5.15.10
Graphics Platform: Wayland
Gwenview: 23.04.3
Comment 4 Pedro 2024-09-15 22:38:33 UTC
What is the expected behavior for keys and shortcuts in general? I see the following scenarios.

Case 1
Currently, if no shortcut is set and you press Ctrl+left/right (arrows) in
  - thumbnail view: only the first image is selected but the cursor moves to the neighbor image (either left or right). Same if you use up/down arrows.
  - image view (focus on the image): nothing happens.
  - thumbnail bar: extended selection. Split view.
  - full screen: nothing happens.

Case 2
If you set a shortcut that involves Ctrl, for instance Ctrl+left/right are previous/next:
  - thumbnail view: extended selection. The neighbor image is selected.
  - image view (focus on the image): nothing happens.
  - thumbnail bar: extended selection. Split view.
  - full screen: extended selection.

First of all, is the current behavior correct for case 1?  In addition, I noticed that if you press shift+left/right in the thumbnail bar nothing happens. Usually, shift is a modifier for extended selection either with arrows or mouse clicks and this works in the case of thumbnail view. If I'm right, Ctrl is usually an individual extended selector with mouse clicks. In image view you can do it also with the keyboard using the space bar, however this doesn't work in Dolphin, for example.

Now, if a shortcut is set as in case 2 above, does it have to take precedence over other behavior? That means using the previous/next shortcut (assuming the shortcut is set to ctrl+left/right) in the thumbnail bar won't split the views. I mention this because there was a MR (https://invent.kde.org/graphics/gwenview/-/merge_requests/210) where that action was lost. However, this happened because the ExtendedSelection flag was removed even if there was no conflict with ctrl+left/right. And if there is no conflict, then the behavior should be the described by @Nikitail (just move to the next image).
Comment 5 Bug Janitor Service 2024-10-05 20:06:43 UTC
A possibly relevant merge request was started @ https://invent.kde.org/graphics/gwenview/-/merge_requests/294