Bug 408881 - Digikam Editor automatically reapplies last edition, even on a different picture
Summary: Digikam Editor automatically reapplies last edition, even on a different picture
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Plugin-Editor-Curves (show other bugs)
Version: 6.2.0
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-06-18 20:13 UTC by Alexandre Belz
Modified: 2019-06-25 20:56 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 6.2.0
Sentry Crash Report:


Attachments
attachment-25915-0.html (2.33 KB, text/html)
2019-06-18 21:06 UTC, Alexandre Belz
Details
attachment-2756-0.html (2.02 KB, text/html)
2019-06-19 08:20 UTC, Alexandre Belz
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alexandre Belz 2019-06-18 20:13:05 UTC
SUMMARY
Not sure if it is a "bug", or a "feature", but each time I open the editor on a different picture from the thumbnail view, I can see the previously modified picture, and then the new one but still keeping the previously made modification  as active.
As ths is not Batch working, I don't want previous edition to apply to another picture !

STEPS TO REPRODUCE
1. From Thumbnail, open a picture in Editor, Edit it, Save it.
2. From Thumbnail, open another picture in Editor
3. In hte editor You can briefly see the old picture
4. then the new picture is loaded
5. but the previous Edition is still applied to the new picture

OBSERVED RESULT
6. I need to click "Reset" or "Default" to revert to a normal situation.

EXPECTED RESULT
I would expect that no Edition step is memorized for a newly loaded picture.
Or at least configurable in the settings.

SOFTWARE/OS VERSIONS
Windows: windows 10
Comment 1 Maik Qualmann 2019-06-18 20:58:59 UTC
The editor window is not closed, just hidden. Therefore, they see the last image. I think it's better than showing an empty window during loading. Nothing is applied to the new image, what do you mean?

Maik
Comment 2 Alexandre Belz 2019-06-18 21:06:54 UTC
Created attachment 120987 [details]
attachment-25915-0.html

Hi Maik,

on my Digikam, i confirm that previous curve edition is systematically reapplied on the latest opened picture, without asking me.

Would it help if i capture a video of my issue ?

BR,
Alex



-------- Message d'origine --------
De : Maik Qualmann <bugzilla_noreply@kde.org>
Date : 18/06/2019 22:59 (GMT+01:00)
À : alexandre.belz@live.fr
Objet : [digikam] [Bug 408881] Digikam Editor automatically reapplies last edition, even on a different picture

https://bugs.kde.org/show_bug.cgi?id=408881

Maik Qualmann <metzpinguin@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |metzpinguin@gmail.com

--- Comment #1 from Maik Qualmann <metzpinguin@gmail.com> ---
The editor window is not closed, just hidden. Therefore, they see the last
image. I think it's better than showing an empty window during loading. Nothing
is applied to the new image, what do you mean?

Maik

--
You are receiving this mail because:
You reported the bug.
Comment 3 Maik Qualmann 2019-06-18 21:12:15 UTC
Almost all tools save their last setting. Also beyond a reboot. That is so wanted and desired.

Maik
Comment 4 Alexandre Belz 2019-06-19 08:20:39 UTC
Created attachment 120992 [details]
attachment-2756-0.html

Thank you Maik for your answer.

i could understand that it would be convenient for applying several times the same edition on similar pictures. But for that we have possibility to "load" previously saved tool settings, or even use "batch" tool to apply same edition to several pictures.

For users who edit different picture each time, this automatic recall complicate the workflow : each time i want to edit luminance curve, i need to reset to defaults (linear) and then start working.
Do you think it could be possible to add a global Editor parameter allowing to enable/disable this automatic tool settings recall ?

Best regards,
Alexandre


-------- Message d'origine --------
De : Maik Qualmann <bugzilla_noreply@kde.org>
Date : 18/06/2019 23:12 (GMT+01:00)
À : alexandre.belz@live.fr
Objet : [digikam] [Bug 408881] Digikam Editor automatically reapplies last edition, even on a different picture

https://bugs.kde.org/show_bug.cgi?id=408881

--- Comment #3 from Maik Qualmann <metzpinguin@gmail.com> ---
Almost all tools save their last setting. Also beyond a reboot. That is so
wanted and desired.

Maik

--
You are receiving this mail because:
You reported the bug.
Comment 5 Alexandre Belz 2019-06-25 06:11:29 UTC
Hi Maik,
Thank you for this clarification. 

Then, can I ask an evolution : I would like a global parameter that makes Editor tools always start with default parameters.

Many thanks ! :)
Comment 6 Maik Qualmann 2019-06-25 20:25:52 UTC
Git commit cb5f13f0a21db4f9bc67546bbeb15fc0d70213f4 by Maik Qualmann.
Committed on 25/06/2019 at 20:22.
Pushed by mqualmann into branch 'master'.

add option to disable the tool setting of the last session
FIXED-IN:6.2.0

M  +2    -1    NEWS
M  +24   -2    core/utilities/imageeditor/editor/editortool.cpp
M  +25   -2    core/utilities/setup/editor/setupeditoriface.cpp

https://invent.kde.org/kde/digikam/commit/cb5f13f0a21db4f9bc67546bbeb15fc0d70213f4
Comment 7 Alexandre Belz 2019-06-25 20:56:48 UTC
Thank you Maik !