Bug 408822 - Rounded corners not being removed for maximised windows
Summary: Rounded corners not being removed for maximised windows
Status: RESOLVED DOWNSTREAM
Alias: None
Product: kwin
Classification: Plasma
Component: decorations (show other bugs)
Version: 5.16.0
Platform: Arch Linux Linux
: NOR normal
Target Milestone: 5
Assignee: KWin default assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-06-17 10:46 UTC by Chris Raven
Modified: 2019-06-18 11:47 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
First screenshot of issue (12.83 KB, image/png)
2019-06-17 10:46 UTC, Chris Raven
Details
Second screenshot of the issue (17.65 KB, image/png)
2019-06-17 10:47 UTC, Chris Raven
Details
OS / KDE / Framework Information (73.89 KB, image/png)
2019-06-17 10:47 UTC, Chris Raven
Details
Top Bar (70.05 KB, image/png)
2019-06-17 10:48 UTC, Chris Raven
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Raven 2019-06-17 10:46:17 UTC
Created attachment 120940 [details]
First screenshot of issue

SUMMARY:

When using any theme that has a rounded corner, and then having that window maximize against Latte Dock, there is a visible gap where the Window Decorations do not change to a squared out view. The rounded corners continue to stay rounded upon maximizing or snapping the window against latte dock. This can be seen in the screenshot presented. This does **not** happen if a standard Plasma Panel is used, only if Latte Dock is used.


STEPS TO REPRODUCE
1. Use the default Breeze Theme,or any other Theme for Window Decorations
2. Have a Latte-Dock bar at the top of your screen
3. Maximize a window or snap windows to the left or right

OBSERVED RESULT:
- The window does not make the decorations square, but keeps them rounded.


EXPECTED RESULT:
- The window decoration should disable the rounded corners, and square them out so that they snap correctly.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Arch Linux -  Kernel: 5.1.9-arch1-1-ARCH
KDE Plasma Version: 5.16.0
KDE Frameworks Version: 5.59.0
Qt Version: 5.12.3

ADDITIONAL INFORMATION:
- As a note, this seems to have been occurring for the last few version of KDE Plasma, and the kernel updates make no difference (not that I expect those to). I have attempted to remove and re-install Latte Dock, and change settings around but nothing has worked. I am only placing this under Latte Dock as it only seems to occur if a Latte Dock Panel or Dock is at the top of the screen
Comment 1 Chris Raven 2019-06-17 10:47:02 UTC
Created attachment 120941 [details]
Second screenshot of the issue
Comment 2 Chris Raven 2019-06-17 10:47:20 UTC
Created attachment 120942 [details]
OS / KDE / Framework Information
Comment 3 Chris Raven 2019-06-17 10:48:14 UTC
Created attachment 120943 [details]
Top Bar

Image of the top bar showing that two windows, snapped side by side, will have a gap where the rounded windows are.
Comment 4 Chris Raven 2019-06-17 10:53:35 UTC
Apologies, I have just removed Latte Dock again and attempted to add a default panel, and found the issue continues, which makes me feel this is more in relation to the way that Windows Decorations are being setup / presented on screen. It is no where near as pronounced with a Plasma Panel though which originally made me believe this was only happening with Latte Dock.

Can we please have this redirected to the correct category for the Window Decorations? I'm unsure what category that would be.
Comment 5 Christoph Feck 2019-06-17 10:57:12 UTC
Which decoration are you using? If unsure, please add the output of kwin support information.
Comment 6 Michail Vourlakos 2019-06-17 11:00:00 UTC
these are not maximized windows but snapped windows OR windows touching the panel
Comment 7 Michail Vourlakos 2019-06-17 11:00:06 UTC
these are not maximized windows but snapped windows OR windows touching the panel
Comment 8 Chris Raven 2019-06-17 12:24:36 UTC
This also occurs if a window is 100% maximized, and touches the window. This also occurs for any window theme that has Rounded corners. Right now I am using the standard Breeze theme.
Comment 9 Michail Vourlakos 2019-06-17 12:41:33 UTC
(In reply to Chris Raven from comment #8)
> This also occurs if a window is 100% maximized, and touches the window. This
> also occurs for any window theme that has Rounded corners. Right now I am
> using the standard Breeze theme.

You can workaround this if you disable window decorations for maximized windows
Comment 10 Nate Graham 2019-06-17 19:44:00 UTC
If you go to System Settings > Application Style > Window Decorations > Breeze > Configure, Have you enabled the setting "Allow resizing maximized windows from window edges"?
Comment 11 Chris Raven 2019-06-18 11:38:44 UTC
Hey Nate.

Thanks for your comment. I can confirm that with that option turned on the issue is present, but upon turning it off, the issue goes away. I suppose that this is actually "By Design" in this case, and each theme would have to have an option to cater for this (Which I am fine with as love the Breeze and Sierra Breeze themes anyway).

I'm happy for you to mark this as resolved if you want :D I don't think additional work needs to be included, unless your team wants to make it a requirement that all Window Decorations have this option included (I don't think that's needed)
Comment 12 Nate Graham 2019-06-18 11:40:42 UTC
That's what I thought. I had a feeling because I filed a similar bug many many moons ago. :)

Basically the solution is to not turn on that option, or lobby your 3rd-party themes to add it.
Comment 13 Michail Vourlakos 2019-06-18 11:47:11 UTC
(In reply to Nate Graham from comment #12)
> That's what I thought. I had a feeling because I filed a similar bug many
> many moons ago. :)
> 
> Basically the solution is to not turn on that option, or lobby your
> 3rd-party themes to add it.

Nice info!