Bug 408744 - Inner Shadow layer style broken since 4.1.x
Summary: Inner Shadow layer style broken since 4.1.x
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Filter Layers (show other bugs)
Version: 4.2.1
Platform: Microsoft Windows Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: Dmitry Kazakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-06-15 16:48 UTC by gabrielborgesbonifacio
Modified: 2019-11-20 15:07 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
What occurs with Inner Shadows Style (448.15 KB, image/png)
2019-06-15 16:48 UTC, gabrielborgesbonifacio
Details
Inner Shadow parameters and effects (108.67 KB, image/png)
2019-06-15 18:25 UTC, Ahab Greybeard
Details
My Inner Shadows parameters (505.54 KB, image/png)
2019-06-15 20:48 UTC, gabrielborgesbonifacio
Details
Example files for Inner Shadow Bug (594.86 KB, application/zip)
2019-06-21 13:53 UTC, Ahab Greybeard
Details

Note You need to log in before you can comment on or make changes to this bug.
Description gabrielborgesbonifacio 2019-06-15 16:48:43 UTC
Created attachment 120891 [details]
What occurs with Inner Shadows Style

When I add Inner Shadows on Layer Style, this occurs:
Comment 1 Scott Petrovic 2019-06-15 17:13:19 UTC
Can you share your KRA file. I just tested it out and the inner shadow seems to be working fine for me. It is hard to tell what thing you have on that vector layer by the screenshot
Comment 2 Ahab Greybeard 2019-06-15 18:25:37 UTC
Created attachment 120898 [details]
Inner Shadow parameters and effects
Comment 3 Ahab Greybeard 2019-06-15 18:27:24 UTC
I forgot to add a comment: What are the parameters you've used for your Inner Shadow and what did you expect to see?
Comment 4 gabrielborgesbonifacio 2019-06-15 20:48:39 UTC
Created attachment 120901 [details]
My Inner Shadows parameters
Comment 5 gabrielborgesbonifacio 2019-06-15 20:50:13 UTC
(In reply to Ahab Greybeard from comment #3)
> I forgot to add a comment: What are the parameters you've used for your
> Inner Shadow and what did you expect to see?

https://bugs.kde.org/attachment.cgi?id=120901
Comment 6 Ahab Greybeard 2019-06-15 21:05:12 UTC
Your latest attachment shows the Blending Options parameters which haven't been implemented yet. You need to click on the name "Inner Shadow" so that it is highlighted, as in my attached screenshot. Ticking the box applies the layer effect. Clicking the name selects the parameters for display and adjustment.

I suspect that the 4.1.x default parameters for that layer effect are different from the current ones and that may be why you feel the effect is 'wrong'.

Again, what do you expect to see? What did 4.1.x do that was acceptable to you?
You need to try adjusting the Inner Shadow layer effect parameters.
Comment 7 Bug Janitor Service 2019-06-16 04:33:15 UTC
Thanks for your comment!

Automatically switching the status of this bug to REPORTED so that the KDE team
knows that the bug is ready to get confirmed.

In the future you may also do this yourself when providing needed information.
Comment 8 Ahab Greybeard 2019-06-21 13:53:51 UTC
Created attachment 121058 [details]
Example files for Inner Shadow Bug

I realise what's happening now and I confirm this bug for 4.1.7 and 4.2.1 using Linux appmages and Windows portable .zip versions. It's also in the latest 4.3.0 pre-alpha appimage.

The bug report author is concered about the red horizontal and vertical lines which are artefacts and are not associated with the original image.

This happens with certain parameter setting of the Inner Shadow Layer Styles.
It's made worse by large Distance, large Choke and small Size.
The artefacts seem to be associated with image content bounding boxes and their placement is affected by the lighting Angle.
They are often persistent when the image layer is turned off and then can be removed by turning the background layer off.
There is often a transient artefact when the Layer Style parameters are altered.
Changing layer positions can result in other persistent artefacts.
Moving layer content often results in another moved copy of the associated artefact.
The bug is not affected by clearing configuration files.

Sample-InnerShadow-Bug.kra in the attached .zip file can be used to observe and investigate this bug.
Comment 9 Dmitry Kazakov 2019-11-20 13:27:05 UTC
After my refactoring of layer styles, the bug is not reproducible in master. But these patches were not backported to 4.2. I'm not sure what we should do with it.
Comment 10 Halla Rempt 2019-11-20 13:27:31 UTC
Is it a lot of work to backport those patches?
Comment 11 Dmitry Kazakov 2019-11-20 14:58:00 UTC
I'm triaging right now. If I confirm that these patches caused the fix, then we should postpone releasing this fix till 4.3, because they change how layer styles are rendered significantly.

I'm checking it right now.
Comment 12 Dmitry Kazakov 2019-11-20 15:07:01 UTC
Okay, I have checked. The bug was fixed when merging the layer styles update. I cannot backport the fix without backporting the entire merge, which will significantly change Krita rendering behavior. We cannot backport it into a "bugfix" release :(

So, just wait till 4.3 is released or use Krita Nightly.