Bug 408702 - [SDDM theme] Menus are not consistent with desktop
Summary: [SDDM theme] Menus are not consistent with desktop
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Theme - Breeze (show other bugs)
Version: master
Platform: Other Linux
: NOR normal
Target Milestone: 1.0
Assignee: visual-design
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-06-14 18:35 UTC by Filip Fila
Modified: 2019-06-14 18:55 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.16.1
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Fila 2019-06-14 18:35:17 UTC
SUMMARY
In the SDDM theme the keyboard layout and session chooser menus look stylistically out of place, i.e. they don't look their desktop equivalents.

They're following QML's default theming because SDDM can't pick up on Plasma style for QQC. We can style the menus manually, however.
Comment 1 Filip Fila 2019-06-14 18:50:24 UTC
Git commit 16d3eb60a9849151aa92c2a100872ab12bb3855d by Filip Fila, on behalf of Carson Black.
Committed on 14/06/2019 at 18:49.
Pushed by filipf into branch 'Plasma/5.16'.

[sddm-theme] Style the session and keyboard layout selectors to be more Breeze

Summary:
The session selector's and keyboard layout's menus are now styled to resemble the Breeze theme rather than the default QML style.

Test Plan: Ensure the styling looks good regardless of various conditions. (resolution, dpi, distro, amount of sessions, etc.)

Reviewers: #vdg, filipf

Reviewed By: #vdg, filipf

Subscribers: apol, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D21794

A  +25   -0    sddm-theme/BreezeMenuStyle.qml     [License: UNKNOWN]  *
M  +1    -0    sddm-theme/KeyboardButton.qml
M  +1    -0    sddm-theme/SessionButton.qml

The files marked with a * at the end have a non valid license. Please read: https://community.kde.org/Policies/Licensing_Policy and use the headers which are listed at that page.


https://commits.kde.org/plasma-workspace/16d3eb60a9849151aa92c2a100872ab12bb3855d