Bug 408686 - Welcome screen: changing themes hides community link
Summary: Welcome screen: changing themes hides community link
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Usability (show other bugs)
Version: nightly build (please specify the git hash!)
Platform: Microsoft Windows Microsoft Windows
: NOR minor
Target Milestone: ---
Assignee: Scott Petrovic
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-06-14 12:47 UTC by Scott Petrovic
Modified: 2019-06-20 10:49 UTC (History)
1 user (show)

See Also:
Latest Commit: https://invent.kde.org/kde/krita/commit/dae9da372ec4e4eb424d8675d377f4f80495bd52
Version Fixed In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Scott Petrovic 2019-06-14 12:47:28 UTC 
SUMMARY
For some reason in Krita 4.2, the Community links do not change when changing themes. I thought it worked before, but maybe it was never tested.

Quite a few things do change theme colors, so it works in some situations. I noticed that in KisWelcomePage.cpp, a lot of those links use HTML with setText(), so it might be something related to that.


STEPS TO REPRODUCE
1. Start Krita
2. Change theme from dark to light


OBSERVED RESULT
Look at the community links color not update


EXPECTED RESULT
community links colors become dark like other items


SOFTWARE/OS VERSIONS
Windows: 10
Qt Version: 

ADDITIONAL INFORMATION
Comment 1 tusooa 2019-06-14 12:54:43 UTC 
Can confirm this. But it happens only when you switch to "krita-bright."
Comment 2 Scott Petrovic 2019-06-17 14:08:30 UTC 
I think I have a fix for this. I am going to take it
Comment 3 Scott Petrovic 2019-06-17 22:15:27 UTC 
Git commit 2a510033d97e5f885c8696097c35bb97013aa0b6 by Scott Petrovic.
Committed on 17/06/2019 at 22:14.
Pushed by scottpetrovic into branch 'master'.

M  +18   -14   libs/ui/KisWelcomePageWidget.cpp

https://invent.kde.org/kde/krita/commit/2a510033d97e5f885c8696097c35bb97013aa0b6
Comment 4 Halla Rempt 2019-06-20 10:49:21 UTC 
Git commit dae9da372ec4e4eb424d8675d377f4f80495bd52 by Boudewijn Rempt, on behalf of Scott Petrovic.
Committed on 20/06/2019 at 10:31.
Pushed by rempt into branch 'krita/4.2'.

M  +18   -14   libs/ui/KisWelcomePageWidget.cpp

https://invent.kde.org/kde/krita/commit/dae9da372ec4e4eb424d8675d377f4f80495bd52