Bug 408566 - Notifications Plasmoid on Latte Dock has disappearing icon
Summary: Notifications Plasmoid on Latte Dock has disappearing icon
Status: RESOLVED FIXED
Alias: None
Product: lattedock
Classification: Plasma
Component: application (show other bugs)
Version: 0.8.8
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Michail Vourlakos
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-06-11 13:32 UTC by The Feren OS Dev
Modified: 2019-06-15 13:03 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 0.8.9


Attachments
My Latte Dock configuration (2.07 KB, text/plain)
2019-06-11 13:32 UTC, The Feren OS Dev
Details
Latte Dock before KDE neon 5.16.0 (4.92 KB, image/png)
2019-06-11 13:32 UTC, The Feren OS Dev
Details
Latte Dock after KDE neon 5.16.0 (4.39 KB, image/png)
2019-06-11 13:33 UTC, The Feren OS Dev
Details

Note You need to log in before you can comment on or make changes to this bug.
Description The Feren OS Dev 2019-06-11 13:32:09 UTC
Created attachment 120785 [details]
My Latte Dock configuration

I've noticed that, on my Latte Dock configuration at least, the notifications icon for the Notifications Plasmoid ,when put on Latte Dock, mysteriously disappears on Breeze Plasma Themes. This bug does not occur on standard Plasma Panels in Plasma 5.16.0 and the Plasmoid still functions properly outside of the lack of an icon on the dock itself.


STEPS TO REPRODUCE
1. Put the Notifications Plasmoid on the Latte Dock, or use the layout provided in the attachments
2. The icon should suddenly disappear out of nowhere for Notifications

OBSERVED RESULT
The Notifications Plasmoid is icon-less on Latte Dock

EXPECTED RESULT
The Notifications Plasmoid would have an icon on Latte Dock.

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 5.16.0, KDE neon 5.16.0
(available in About System)
KDE Plasma Version: 5.16.0
KDE Frameworks Version: 5.59.0
Qt Version: 5.12.3

ADDITIONAL INFORMATION
This bug didn't ever happen on KDE neon 5.15's version of Latte Dock.
Comment 1 The Feren OS Dev 2019-06-11 13:32:48 UTC
Created attachment 120786 [details]
Latte Dock before KDE neon 5.16.0
Comment 2 The Feren OS Dev 2019-06-11 13:33:17 UTC
Created attachment 120787 [details]
Latte Dock after KDE neon 5.16.0
Comment 3 The Feren OS Dev 2019-06-11 13:34:48 UTC
Note: While the screenshots show a custom Breeze-based theme in action on Latte Dock, I've also tested it on the standard Breeze themes to have the exact same issue.
Comment 4 Michail Vourlakos 2019-06-11 13:38:15 UTC
I wouldn't be surprised if Latte heuristics broke in plasma 5.16
Comment 5 avlas 2019-06-12 19:06:48 UTC
(In reply to Michail Vourlakos from comment #4)
> I wouldn't be surprised if Latte heuristics broke in plasma 5.16

It works for my in Latte 0.8.8 after removing and re-adding notification in latte's system tray.

However, notifications are displayed in the center of the screen.
Comment 6 avlas 2019-06-12 19:12:56 UTC
(In reply to Michail Vourlakos from comment #4)
> I wouldn't be surprised if Latte heuristics broke in plasma 5.16

Please take a look at https://bugs.kde.org/show_bug.cgi?id=407757#c21
Comment 7 The Feren OS Dev 2019-06-12 19:36:20 UTC
(In reply to avlas from comment #5)
> (In reply to Michail Vourlakos from comment #4)
> > I wouldn't be surprised if Latte heuristics broke in plasma 5.16
> 
> It works for my in Latte 0.8.8 after removing and re-adding notification in
> latte's system tray.
> 
> However, notifications are displayed in the center of the screen.

Try adding Notifications individually to the Latte Dock instead of inside the System Tray applet. Probably should have mentioned that but my notifications applet is outside of the System Tray applet and is instead its own instance on the Latte Dock itself. When the same thing is done on a Plasma Panel this issue does not occur, only when it's on a Latte Dock.
Comment 8 Michail Vourlakos 2019-06-12 19:50:53 UTC
(In reply to The Feren OS Dev from comment #7)
> (In reply to avlas from comment #5)
> > (In reply to Michail Vourlakos from comment #4)
> > > I wouldn't be surprised if Latte heuristics broke in plasma 5.16
> > 
> > It works for my in Latte 0.8.8 after removing and re-adding notification in
> > latte's system tray.
> > 
> > However, notifications are displayed in the center of the screen.
> 
> Try adding Notifications individually to the Latte Dock instead of inside
> the System Tray applet. Probably should have mentioned that but my
> notifications applet is outside of the System Tray applet and is instead its
> own instance on the Latte Dock itself. When the same thing is done on a
> Plasma Panel this issue does not occur, only when it's on a Latte Dock.

[1] Let me give you some info. There is a MAJOR Plasma limitation concerning Icons. In Plasma Icons we have the following MAJOR Principle "Icons should NEVER look blurred". So to achieve this goal Plasma is using PlasmaCore.IconItem and I suppose in the future something in Kirigami that in order to achieve this icons are drawn ONLY from sizes provided from the active ICON THEME when the size requested is BELOW 64px. For icon sizes >=64px. there is no problem.

[2] Latte on the other hand has another goal "Smoothness during Parabolic effect as FIRST GOAL and avoiding icon blurness is not mandatory". If the user chooses an Items Size that is provided from their icon theme then blurness is not appearing in Latte. To achieve this Latte is providing a fork for PlasmaCore.IconItem that is called Latte.IconItem

Applets: Because applets developers and plasma applets are not considering [2] case as valid Latte is doing some automatic heuristics. Latte when a plasma applet loads searches in it to find the PlasmaCore.IconItem that is used when this applet is shown in the panel and IF that IconItem is found then Latte disables it and overlays above it a Latte.IconItem. Nasty workaround I know but it works. The heuristic mechanism can take blacklisting of applets in order to not be used or whitelisting which means that Latte has a specific way for this applet in order to reach at its PlasmaCore.IconItem

So problems like this first need to be investigated from Latte side to identify if the Latte heuristics became invalid somehow...

when plasma 5.16 reaches my system I will have more information.
Comment 9 Michail Vourlakos 2019-06-12 19:51:17 UTC
(In reply to avlas from comment #6)
> (In reply to Michail Vourlakos from comment #4)
> > I wouldn't be surprised if Latte heuristics broke in plasma 5.16
> 
> Please take a look at https://bugs.kde.org/show_bug.cgi?id=407757#c21

they dont seem related but I will be sure only when plasma 5.16 reaches my system
Comment 10 Michail Vourlakos 2019-06-12 20:33:42 UTC
Git commit ffd0bef61192ff11e3bdee3874fba7fd3ad010d8 by Michail Vourlakos.
Committed on 12/06/2019 at 20:31.
Pushed by mvourlakos into branch 'master'.

blacklist plasma notifications in heuristics

--plasma notification applet has become more complex
lets blacklist it in order to provide the real
plasma experience and see how it goes

M  +2    -1    containment/package/contents/code/AppletIdentifier.js

https://commits.kde.org/latte-dock/ffd0bef61192ff11e3bdee3874fba7fd3ad010d8
Comment 11 Michail Vourlakos 2019-06-12 20:39:53 UTC
Git commit ec284dbfa8d7f00083e506e1f9a87eb37f835192 by Michail Vourlakos.
Committed on 12/06/2019 at 20:39.
Pushed by mvourlakos into branch 'v0.8'.

blacklist plasma notifications in heuristics

--plasma notification applet has become more complex
lets blacklist it in order to provide the real
plasma experience and see how it goes
FIXED-IN: 0.8.9

M  +2    -1    containment/package/contents/code/AppletIdentifier.js

https://commits.kde.org/latte-dock/ec284dbfa8d7f00083e506e1f9a87eb37f835192
Comment 12 Michail Vourlakos 2019-06-12 20:40:49 UTC
blacklisted in Latte heuristics and this is fixed
Comment 13 The Feren OS Dev 2019-06-12 20:43:20 UTC
I'll be sure to check it when Latte drops in KDE neon Git Unstable and will come back to you in case it still occurs on my side, though I'm assuming this means you now have Plasma 5.16.0 and therefore have been able to see the issue and have 'fixed' it.
Comment 14 Michail Vourlakos 2019-06-12 20:44:31 UTC
(In reply to The Feren OS Dev from comment #13)
> I'll be sure to check it when Latte drops in KDE neon Git Unstable and will
> come back to you in case it still occurs on my side, though I'm assuming
> this means you now have Plasma 5.16.0 and therefore have been able to see
> the issue and have 'fixed' it.

yep, I managed to build plasma master after a month of problems with kdesrc-build in my system and now the issue does not occur for me
Comment 15 avlas 2019-06-13 00:45:52 UTC
(In reply to Michail Vourlakos from comment #11)
> Git commit ec284dbfa8d7f00083e506e1f9a87eb37f835192 by Michail Vourlakos.
> Committed on 12/06/2019 at 20:39.
> Pushed by mvourlakos into branch 'v0.8'.
> 
> blacklist plasma notifications in heuristics
> 
> --plasma notification applet has become more complex
> lets blacklist it in order to provide the real
> plasma experience and see how it goes
> FIXED-IN: 0.8.9
> 
> M  +2    -1    containment/package/contents/code/AppletIdentifier.js
> 
> https://commits.kde.org/latte-dock/ec284dbfa8d7f00083e506e1f9a87eb37f835192

Mmm, after applying this change, I don't see any notification anymore :(
Comment 16 Michail Vourlakos 2019-06-13 04:21:28 UTC
(In reply to avlas from comment #15)
> (In reply to Michail Vourlakos from comment #11)
> > Git commit ec284dbfa8d7f00083e506e1f9a87eb37f835192 by Michail Vourlakos.
> > Committed on 12/06/2019 at 20:39.
> > Pushed by mvourlakos into branch 'v0.8'.
> > 
> > blacklist plasma notifications in heuristics
> > 
> > --plasma notification applet has become more complex
> > lets blacklist it in order to provide the real
> > plasma experience and see how it goes
> > FIXED-IN: 0.8.9
> > 
> > M  +2    -1    containment/package/contents/code/AppletIdentifier.js
> > 
> > https://commits.kde.org/latte-dock/ec284dbfa8d7f00083e506e1f9a87eb37f835192
> 
> Mmm, after applying this change, I don't see any notification anymore :(
(In reply to avlas from comment #15)
> (In reply to Michail Vourlakos from comment #11)
> > Git commit ec284dbfa8d7f00083e506e1f9a87eb37f835192 by Michail Vourlakos.
> > Committed on 12/06/2019 at 20:39.
> > Pushed by mvourlakos into branch 'v0.8'.
> > 
> > blacklist plasma notifications in heuristics
> > 
> > --plasma notification applet has become more complex
> > lets blacklist it in order to provide the real
> > plasma experience and see how it goes
> > FIXED-IN: 0.8.9
> > 
> > M  +2    -1    containment/package/contents/code/AppletIdentifier.js
> > 
> > https://commits.kde.org/latte-dock/ec284dbfa8d7f00083e506e1f9a87eb37f835192
> 
> Mmm, after applying this change, I don't see any notification anymore :(

How is this relevant to notification applet not been visible?
Comment 17 avlas 2019-06-13 10:57:09 UTC
(In reply to Michail Vourlakos from comment #16)
> (In reply to avlas from comment #15)
> > (In reply to Michail Vourlakos from comment #11)
> > > Git commit ec284dbfa8d7f00083e506e1f9a87eb37f835192 by Michail Vourlakos.
> > > Committed on 12/06/2019 at 20:39.
> > > Pushed by mvourlakos into branch 'v0.8'.
> > > 
> > > blacklist plasma notifications in heuristics
> > > 
> > > --plasma notification applet has become more complex
> > > lets blacklist it in order to provide the real
> > > plasma experience and see how it goes
> > > FIXED-IN: 0.8.9
> > > 
> > > M  +2    -1    containment/package/contents/code/AppletIdentifier.js
> > > 
> > > https://commits.kde.org/latte-dock/ec284dbfa8d7f00083e506e1f9a87eb37f835192
> > 
> > Mmm, after applying this change, I don't see any notification anymore :(
> (In reply to avlas from comment #15)
> > (In reply to Michail Vourlakos from comment #11)
> > > Git commit ec284dbfa8d7f00083e506e1f9a87eb37f835192 by Michail Vourlakos.
> > > Committed on 12/06/2019 at 20:39.
> > > Pushed by mvourlakos into branch 'v0.8'.
> > > 
> > > blacklist plasma notifications in heuristics
> > > 
> > > --plasma notification applet has become more complex
> > > lets blacklist it in order to provide the real
> > > plasma experience and see how it goes
> > > FIXED-IN: 0.8.9
> > > 
> > > M  +2    -1    containment/package/contents/code/AppletIdentifier.js
> > > 
> > > https://commits.kde.org/latte-dock/ec284dbfa8d7f00083e506e1f9a87eb37f835192
> > 
> > Mmm, after applying this change, I don't see any notification anymore :(
> 
> How is this relevant to notification applet not been visible?

Not relevant, sorry, got confused. Will open a new bug
Comment 18 The Feren OS Dev 2019-06-15 13:03:17 UTC
I can confirm through my KDE neon Unstable VM that this was indeed fixed. Thanks!