Bug 408513 - Piwigo export does not save connection details
Summary: Piwigo export does not save connection details
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Plugin-WebService-Piwigo (other bugs)
Version First Reported In: 6.1.0
Platform: Appimage Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-06-10 09:32 UTC by Christian Frommeyer
Modified: 2019-06-10 19:10 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In: 6.2.0
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Frommeyer 2019-06-10 09:32:12 UTC
SUMMARY
After exporting images to Piwigo and closing the dialog the connection details are not saved.
I'm using DigiKam 6.1.0 AppImage. At least until 5.9.0 this has been working with the Kipi-Plugin. Connection details were stored in the ~/.config/kipirc file. Now I guess the plugin has been ported to the new Plugin architecture yet saving the settings seems to be missing.

STEPS TO REPRODUCE
1. Open "Export to Piwigo" dialog
2. Enter connection details
3. Make sure connection works fine
4. Close dialog
5. Reopen dialog
6. Observe that the connection details were not saved

OBSERVED RESULT
Piwigo Connection details are not saved

EXPECTED RESULT
Piwigo connection details are saved so that I do not need to enter them for each upload.

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 5.15.4
KDE Frameworks Version: 5.56.0
Qt Version: 5.12.2

ADDITIONAL INFORMATION
Comment 1 caulier.gilles 2019-06-10 09:50:23 UTC
The new plugin architecture is not shared with other KDE application anymore.

The plugin settings is simply saved now in... ~/.config/digikamrc file.

Can you try with 6.2.0 pre-release Linux AppImage bundle to see if this problem is not yet solved ?

https://files.kde.org/digikam/

Gilles Caulier
Comment 2 Maik Qualmann 2019-06-10 09:56:40 UTC
I can not reproduce the problem and see no error in the code.

Maik
Comment 3 Maik Qualmann 2019-06-10 10:21:45 UTC
Git commit 56bfea5cff98074e4d074856a93223fb95a28af7 by Maik Qualmann.
Committed on 10/06/2019 at 10:20.
Pushed by mqualmann into branch 'master'.

fix loading Piwigo settings in the second session
FIXED-IN: 6.2.0

M  +2    -1    NEWS
M  +0    -9    core/dplugins/generic/webservices/piwigo/piwigosession.cpp

https://invent.kde.org/kde/digikam/commit/56bfea5cff98074e4d074856a93223fb95a28af7
Comment 4 Christian Frommeyer 2019-06-10 11:05:00 UTC
Wow that was amazing fast!!

I can confirm it does work with the 6.2.0 pre-release from 6/6.
Thank you for pointing me to this.

Keep up the good work, much appreciated!
Christian
Comment 5 Christian Frommeyer 2019-06-10 12:58:16 UTC
Unfortunately I have to correct myself here. It worked once with 'digikam-6.2.0-git-20190606T125502-qtwebkit-x86-64.appimage'. Yet it is not working any more. I digged a little deeper and in fact the connection details are written to the configuration file. Also the saved data is used once after starting the application. However subsequent exports fail as the configuration gets reset.

I tried to use strace to get some information but failed. Is there anything else I could try?

Christian
Comment 6 caulier.gilles 2019-06-10 13:01:06 UTC
In fact, please wait, i will rebuild the AppImage bundle with last fixes from Maik committed today.

Gilles Caulier
Comment 7 Maik Qualmann 2019-06-10 13:55:10 UTC
With the AppImage from 06.06 the error can not be solved. And the mistake only occurred with the 2nd Piwigo Sizung. I close again...

Maik
Comment 8 Christian Frommeyer 2019-06-10 19:10:44 UTC
Great that did it. Sorry for getting it wrong the first time. I didn't realize the fixes were that fresh. I did a bit of additional testing to be sure. But looks like it is now behaving as expected.

Thanks again
Christian