Bug 408478 - Placeholder text for the username does not conform to actual requirements
Summary: Placeholder text for the username does not conform to actual requirements
Status: RESOLVED FIXED
Alias: None
Product: user-manager
Classification: Plasma
Component: kcontrol module (show other bugs)
Version: 5.15.90
Platform: Arch Linux Linux
: NOR minor
Target Milestone: ---
Assignee: Jonathan Riddell
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-06-09 09:41 UTC by Alexey Boltenko
Modified: 2019-06-28 20:39 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.17.0


Attachments
Screenshot (42.06 KB, image/png)
2019-06-09 09:41 UTC, Alexey Boltenko
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Boltenko 2019-06-09 09:41:14 UTC
Created attachment 120718 [details]
Screenshot

SUMMARY
Placeholder text for the username is not consistent to actual requirements

STEPS TO REPRODUCE
1. Open the User Manager

OBSERVED RESULT
Username field's placeholder is inconsistent

EXPECTED RESULT
It should start with a lowercase letter

SOFTWARE/OS VERSIONS
Linux: 5.1.7-arch1-1-ARCH
KDE Plasma Version: 5.15.90
KDE Frameworks Version: 5.58.0
Qt Version: 5.13.0

ADDITIONAL INFORMATION
The first letter must specifically be lowercase.
This might be relevant (from user-manager source; src/accountinfo.cpp):
QString AccountInfo::cleanUsername(QString username)
{
    if (username.isEmpty()) {
        return username;
    }

    if (username[0].isUpper()) {
        username[0] = username[0].toLower();
    }

    username.remove(QLatin1Char(' '));
    m_info->username->setText(username);
    return username;
}
Comment 1 Filip Fila 2019-06-26 15:14:25 UTC
Are you sure it's not only for this new user (John Doe)? It's a problem with the placeholder text I think
Comment 2 Filip Fila 2019-06-28 20:39:10 UTC
Git commit f78202c2face8d64af63281fd4c4eb4237314cc5 by Filip Fila.
Committed on 28/06/2019 at 20:38.
Pushed by filipf into branch 'master'.

Do not capitalize placeholder username

Summary:
The current placeholder text for the username is "John". Usernames can't be capitalized so change it to "john".
FIXED-IN: 5.17.0

Reviewers: #plasma, ngraham

Reviewed By: ngraham

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D22104

M  +1    -1    src/account.ui

https://commits.kde.org/user-manager/f78202c2face8d64af63281fd4c4eb4237314cc5