Bug 408435 - Left sidebar wont follow system dark scheme
Summary: Left sidebar wont follow system dark scheme
Status: RESOLVED FIXED
Alias: None
Product: Elisa
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Matthieu Gallien
URL:
Keywords:
: 409342 (view as bug list)
Depends on:
Blocks:
 
Reported: 2019-06-07 23:13 UTC by Neousr
Modified: 2019-06-30 22:51 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In: 0.4.2


Attachments
Example (141.37 KB, image/png)
2019-06-09 15:22 UTC, Neousr
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Neousr 2019-06-07 23:13:47 UTC
Elisa from git master/unstable branches

STEPS TO REPRODUCE
1. Select a Dark Scheme in system settings
2. Open elisa

OBSERVED RESULT
The left sidebar wont change its color and will stay white same as the background text. Light schemes like breeze work fine.

EXPECTED RESULT
All the Elisa UI should change on the color selected on the system settings.
Comment 1 Martin Steigerwald 2019-06-09 10:46:47 UTC
Hi. Thank for your reporting. With what version was this? I am using Breeze Dark with Elisa 0.4.0 and it looks alright with it.
Comment 2 Neousr 2019-06-09 15:22:23 UTC
Created attachment 120725 [details]
Example

That would be 0.4.80 compiled from source or from neon unstable branches.


0.4.0 Works fine.
Comment 3 Neousr 2019-06-09 15:58:02 UTC
It landed on Neon Testing Edition as well as version 0.4.1. Same behavior.
Comment 4 Martin Steigerwald 2019-06-09 16:37:17 UTC
Strange. Looks right here.

What happens if you restart Elisa after making the configuration change? Currently that is still needed. According to

Nate Graham's KDE Usability & Productivity: Week 74
https://pointieststick.com/2019/06/09/kde-usability-productivity-week-74/

this is fixed in Plasma 5.16.1:

When switching color schemes, all KDE apps’ user interface controls now change their colors without having to quit and re-open them (Sebastian Kügler, KDE Plasma 5.16.1)

See also:

re-read color palettes when application color changes
https://phabricator.kde.org/D21646
Comment 5 Neousr 2019-06-18 22:37:47 UTC
Retested the latest git version on 5.16.1 it was not related to the re-read color palettes issue.
Comment 6 Martin Steigerwald 2019-06-19 06:54:28 UTC
Thanks. Setting as REPORTED again.
Comment 7 Matt Scheirer 2019-06-25 00:12:42 UTC
Note that selected elements in the sidebar seem to have correct theming - IE, click Now Playing, click off window, Now Playing has the correctly set active element background color. The only broken color is the default unselected background.
Comment 8 Matthieu Gallien 2019-06-25 05:31:47 UTC
I am working on it.
Comment 9 Matthieu Gallien 2019-06-25 05:45:23 UTC
https://phabricator.kde.org/D22086 should fix it. If you can test, that would be great !
Comment 10 Neousr 2019-06-25 15:21:04 UTC
Applied the change works as expected again.
Comment 11 Matthieu Gallien 2019-06-25 15:26:22 UTC
Git commit 4bee9b30c4b0f10934d60c46b9f81af69cb516a8 by Matthieu Gallien.
Committed on 25/06/2019 at 15:25.
Pushed by mgallien into branch '0.4'.

the background of the view selector list should be transparent

Summary:
avoid having a big rectangle with a default color not following the
color theme

Test Plan: now playlist is correct with Breeze and BreezeDark

Reviewers: #elisa, zanny, ngraham

Reviewed By: #elisa, zanny, ngraham

Subscribers: neousr, ngraham, zanny

Differential Revision: https://phabricator.kde.org/D22086

M  +0    -13   src/qml/ViewSelector.qml

https://commits.kde.org/elisa/4bee9b30c4b0f10934d60c46b9f81af69cb516a8
Comment 12 Nate Graham 2019-06-30 22:51:31 UTC
*** Bug 409342 has been marked as a duplicate of this bug. ***