Bug 408434 - Crashes just after a composition removal
Summary: Crashes just after a composition removal
Status: RESOLVED FIXED
Alias: None
Product: kdenlive
Classification: Applications
Component: Effects & Transitions (show other bugs)
Version: 20.12.2
Platform: Microsoft Windows Microsoft Windows
: NOR critical
Target Milestone: ---
Assignee: Vincent PINON
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-06-07 22:39 UTC by lucky7tube
Modified: 2021-08-30 21:01 UTC (History)
4 users (show)

See Also:
Latest Commit: https://invent.kde.org/multimedia/kdenlive/commit/ad7cbbb994df4669ce464803eb5931c38ab2a940
Version Fixed In: 21.08.1
fritzibaby: Brainstorm+

Attachments
Crashes when remove a composition (1.56 MB, video/mp4)
2019-06-07 22:39 UTC, lucky7tube 		Details
ko_KR locale uses a point as decimal symbol, not a comma (39.73 KB, image/png)
2019-06-09 12:15 UTC, lucky7tube 		Details
gdb log while kdenlive crashed (51.94 KB, text/x-log)
2020-08-02 05:09 UTC, Cyril Giraud 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description lucky7tube 2019-06-07 22:39:03 UTC 
Created attachment 120681 [details]
Crashes when remove a composition

SUMMARY
Kdenlive just crashes when removing a transition of a clip on the timeline.

STEPS TO REPRODUCE
1. Import a video clip in the project bin
2. Place the clip on the timeline
3. (optional) Split the clip into several pieces, and overlap the pieces
4. Add a composition to some (overlapped or not) piece of the clip
5. Remove the composition previously added

OBSERVED RESULT
Kdenlive crashes immediately

EXPECTED RESULT
Intended composition gets removed and I should be able to keep editing


SOFTWARE/OS VERSIONS
Windows: 7
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
This bug is fresh with v19.04.2, never seen before.
Comment 1 emohr 2019-06-08 12:35:12 UTC 
This looks like the comma/point issue. Please change in the setting from comma to point or the other way around. See here: https://invent.kde.org/kde/kdenlive/issues/78#note_3980 

BTW: such screengrab are always very helpful.
Comment 2 lucky7tube 2019-06-09 12:15:05 UTC 
Created attachment 120723 [details]
ko_KR locale uses a point as decimal symbol, not a comma

(In reply to emohr from comment #1)
> This looks like the comma/point issue. Please change in the setting from
> comma to point or the other way around. See here:
> https://invent.kde.org/kde/kdenlive/issues/78#note_3980 
> 
> BTW: such screengrab are always very helpful.

Thank you for replying.
But I don't understand because it works just fine with v19.04.1.
Moreover, my locale is ko_KR, which uses a point as decimal symbol, not a comma.
Deep consideration about latest changes will be appreciated.
Comment 3 candide 2019-06-16 22:20:06 UTC 
I'm having the exact same issue, either when I try to hit the delete button or when I right click on the transition/composition
Comment 4 emohr 2019-06-17 16:05:26 UTC 
Could you make a test and switching the other way around from point to comma or vis versa to test if the crash is still there. https://invent.kde.org/kde/kdenlive/issues/78#note_3980
Comment 5 candide 2019-06-17 16:32:04 UTC 
(In reply to emohr from comment #4)
> Could you make a test and switching the other way around from point to comma
> or vis versa to test if the crash is still there.
> https://invent.kde.org/kde/kdenlive/issues/78#note_3980

I made the switch (from period to comma) and it still crashed (exactly like the video in attachment).
Comment 6 Cyril Giraud 2020-08-02 05:09:10 UTC 
Created attachment 130565 [details]
gdb log while kdenlive crashed
Comment 7 Cyril Giraud 2020-08-02 05:19:08 UTC 
Crash always reproducible on my Ubuntu Studio 20.04 64bits and kdenlive 20.04.1:
. create a new empty project
. move 1 composition (Addition) to the empty time line
. select spacer tool
. select composition in time line and press "Del" key on keyboard to delete composition
--> crash
Comment 8 Julius Künzel 2021-02-24 21:32:28 UTC 
Same on linux with version 20.12.2 (updated above). It is not only happening with transitions, with the clips too if you use the spacer tool

Additional information:
ASSERT: "isItem(itemId)" in file kdenlive/src/timeline2/model/timelinemodel.cpp, line 263
Comment 9 Jean-Baptiste Mardelle 2021-08-05 16:14:25 UTC 
Git commit ad7cbbb994df4669ce464803eb5931c38ab2a940 by Jean-Baptiste Mardelle.
Committed on 05/08/2021 at 16:07.
Pushed by mardelle into branch 'release/21.08'.

Don't allow deleting items when a spacer move operation is running.

M  +1    -1    src/timeline2/view/qml/timeline.qml
M  +5    -0    src/timeline2/view/timelinecontroller.cpp

https://invent.kde.org/multimedia/kdenlive/commit/ad7cbbb994df4669ce464803eb5931c38ab2a940
Comment 10 Cyril Giraud 2021-08-30 21:01:30 UTC 
Seems solved with kdenlive-21.08.0a-x86_64.appimage
Thanks!