Bug 408419 - Support appstream: URIs as well, not just appstream://
Summary: Support appstream: URIs as well, not just appstream://
Status: RESOLVED FIXED
Alias: None
Product: Discover
Classification: Applications
Component: discover (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Dan Leinir Turthra Jensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-06-07 15:12 UTC by Jonathan Riddell
Modified: 2019-10-28 18:55 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.17.2


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Riddell 2019-06-07 15:12:49 UTC
Appstream URLs should not have the :// only the :

Although they can work equally well with the //

Discover requires the :// which is incorrect.

The docs were misleading on this point and have no been updated
https://www.freedesktop.org/software/appstream/docs/sect-AppStream-Services-URIHandler.html

The buttons show in those docs are incorrect.

I can currently using the :// on the kde.org/applications website but would like to make it correct.
Comment 1 Jonathan Riddell 2019-06-07 15:13:22 UTC
"have now been updated" I mean
Comment 2 Jonathan Riddell 2019-10-17 10:56:37 UTC
still an issue in 5.17
Comment 3 Aleix Pol 2019-10-28 18:50:41 UTC
Git commit 4f2aa69241717a12e09bd49aba9ff78bd202960a by Aleix Pol.
Committed on 28/10/2019 at 18:50.
Pushed by apol into branch 'Plasma/5.17'.

appstream: support more formats of appstream urls

Centralises decoding of the urls into the same place.
Uses both host and path to get the appstream id, since different people
do it in different ways.

M  +5    -0    libdiscover/appstream/AppStreamUtils.cpp
M  +2    -0    libdiscover/appstream/AppStreamUtils.h
M  +4    -2    libdiscover/backends/FlatpakBackend/FlatpakBackend.cpp
M  +7    -8    libdiscover/backends/PackageKitBackend/PackageKitBackend.cpp
M  +2    -1    libdiscover/backends/SnapBackend/SnapBackend.cpp

https://commits.kde.org/discover/4f2aa69241717a12e09bd49aba9ff78bd202960a