Created attachment 120557 [details] new okular annotation toolbar I am working on a new annotation toolbar for Okular (see attachment and https://phabricator.kde.org/T8076) Some new icons to represent the annotation tools are required, so I am opening this bug to request them. I also appreciate help on the thinking part of the new icons, and any feedback on the already chosen one. LIST OF ANNOTATIONS AND CORRESPONDING ICONS Highlighter: TODO Underline: format-text-underline Squiggle underline: TODO Strikeout: format-text-strikethrough Typewriter: text-convert-to-regular (is this OK?) Inline note: note (is this OK?) Popup note: edit-comment Freehand annotation: draw-freehand Straight line: draw-line Arrow: TODO Rectangle: draw-rectangle Ellipse: draw-ellipse Polygon: draw-polyline LIST OF ANNOTATION CONFIGURATIONS AND CORRESPONDING ICONS Color: TODO Inner color: TODO Font selector: font-face Pin annotation: TODO REQUESTED ICONS - Highlighter: An icon to represent an highlighter. Currently draw-erase is used as temporary icon. Something similar to it would be good. - Squiggle underline: Something similar to format-text-underline, but the underline line should be a zig-zag line. - Arrow: A straight arrow. Does not this exist yet? As a temporary icon I am using circular-arrow-shape - Color: An icon with a colorizable part to indicate the current color. I was thinking at a circle with a border where the inner part has a color that is not transparent so that I can call something like: iconPixmap.createMaskFromColor(QColor(...), Qt::MaskOutColor); or something better. Inner color: similar to color, but able to represent that the background will be filled. Like the color-fill icon. - Pin annotation: An icon to represent the fact that if the corresponding action is checked the annotation tools will not be deselected automatically after use. I was thinking at a 'board pin'.
Created attachment 122217 [details] Color selection icons in Libreoffice (top) and Calligra (bottom) My thoughts on this request: Highlighter: A new icon is needed and should not be too hard to make. Squiggle underline: A variant of format-text-underline should be possible. Typewriter: While I can see why you like text-convert-to-regular, using that icon here is not quite semantically correct. I think it would be more standard to use either insert-text or insert-text-frame depending on whether the tool allows you to type freely or requires you to draw a bounding box for the text. Inline note: note fits this quite well, but I do wonder if a insert-note icon with a little plus sign in the bottom right corner would be more appropriate. Arrow: A draw-arrow icon that looks like draw-line but with an arrowhead should fit nicely. Color and inner color: It might be easier to take the approach that Calligra and LibreOffice have regarding this (see attached screenshot), which is to use the format-text-color and format-fill-color icons and overlay a rectangle in the selected color on those. I think this approach is better because it ensures legibility of the icon regardless of the selected color and it is probably better for compatability with third party icon sets. Pin annotation: What do you think of window-pin? We can make a symlink to another name like edit-pinned or something like that.
(In reply to Rafael Brandmaier from comment #1) > Highlighter: A new icon is needed and should not be too hard to make. +1 > Squiggle underline: A variant of format-text-underline should be possible. +1 > Typewriter: While I can see why you like text-convert-to-regular, using that > icon here is not quite semantically correct. I think it would be more > standard to use either insert-text or insert-text-frame depending on whether > the tool allows you to type freely or requires you to draw a bounding box > for the text. +1 for using one of those here rather than making a new icon. Can you mention this in https://phabricator.kde.org/D15580? > Inline note: note fits this quite well, but I do wonder if a insert-note > icon with a little plus sign in the bottom right corner would be more > appropriate. +1, that sounds appropriate. Let's make sure to always use a plus sign in the corner for tools that add new things seems like a good idea to me for comprehensibility's sake. > Arrow: A draw-arrow icon that looks like draw-line but with an arrowhead > should fit nicely. Yeah, and maybe we should add a little plus sign for this one too. > Color and inner color: It might be easier to take the approach that Calligra > and LibreOffice have regarding this (see attached screenshot), which is to > use the format-text-color and format-fill-color icons and overlay a > rectangle in the selected color on those. I think this approach is better > because it ensures legibility of the icon regardless of the selected color > and it is probably better for compatability with third party icon sets. That does sound like it makes sense to me. Can you mention this in https://phabricator.kde.org/D15580? > Pin annotation: What do you think of window-pin? We can make a symlink to > another name like edit-pinned or something like that. The `pin` icon seems inaccurate since the icon depicts a location marker, not a pin. I just fixed that with https://commits.kde.org/breeze-icons/53bbac34aa2e755a06a4b0be21cf9b616d5e8769. So now no changes are necessary to this in Okular.
Thanks for all the comments. I originally picked the icons more or less randomly looking at them using cuttlefish, so this type of guidance is what I was looking for. (In reply to Nate Graham from comment #2) > (In reply to Rafael Brandmaier from comment #1) > > Highlighter: A new icon is needed and should not be too hard to make. > +1 +1 > > > Squiggle underline: A variant of format-text-underline should be possible. > +1 > +1 > > Arrow: A draw-arrow icon that looks like draw-line but with an arrowhead > > should fit nicely. > Yeah, and maybe we should add a little plus sign for this one too. > I would not add the plus sign. The other tools in the same menu (straight line, rectangle, etc) do not have the plus sign. Given their location in a toolbar intended to add annotations should already be enough to make their intent clear. For example in LibreOffice {nav Insert > Shape} menu the icons do not have a plus sign. > > Inline note: note fits this quite well, but I do wonder if a insert-note > > icon with a little plus sign in the bottom right corner would be more > > appropriate. > +1, that sounds appropriate. Let's make sure to always use a plus sign in > the corner for tools that add new things seems like a good idea to me for > comprehensibility's sake. > Ok for me, though it will be slightly inconsistent with the popup note icon (edit-comment) next to it that does not have the plus sign (or all the other icons that do not have a plus sign). Again, the place in the toolbar should make the intent clear. > > Typewriter: While I can see why you like text-convert-to-regular, using that > > icon here is not quite semantically correct. I think it would be more > > standard to use either insert-text or insert-text-frame depending on whether > > the tool allows you to type freely or requires you to draw a bounding box > > for the text. > +1 for using one of those here rather than making a new icon. Can you > mention this in https://phabricator.kde.org/D15580? > Changed in D15580, though I have a second thought now. Maybe tool-text is more appropriate? In Kolourpaint, which has a toolbar somewhat similar to the one of Okular (insert text, shapes, etc) this is the icon used to insert text. In this way this would not be the only icon in the toolbar with a plus sign (see comments for inline note and arrow). Bottom-line: I would not add the plus sign to any icon. > > Color and inner color: It might be easier to take the approach that Calligra > > and LibreOffice have regarding this (see attached screenshot), which is to > > use the format-text-color and format-fill-color icons and overlay a > > rectangle in the selected color on those. I think this approach is better > > because it ensures legibility of the icon regardless of the selected color > > and it is probably better for compatability with third party icon sets. > That does sound like it makes sense to me. Can you mention this in > https://phabricator.kde.org/D15580? > I think this is perfect. I'll change this soon. > > Pin annotation: What do you think of window-pin? We can make a symlink to > > another name like edit-pinned or something like that. > The `pin` icon seems inaccurate since the icon depicts a location marker, > not a pin. I just fixed that with > https://commits.kde.org/breeze-icons/ > 53bbac34aa2e755a06a4b0be21cf9b616d5e8769. So now no changes are necessary to > this in Okular. Changed. (Originally I used the icon 'port' instead of 'pin', which is also a location marker. Probably also the icon for 'port' should be reworked.)
(In reply to Simone Gaiarin from comment #3) > Changed. (Originally I used the icon 'port' instead of 'pin', which is also > a location marker. Probably also the icon for 'port' should be reworked.) Thanks for the heads-up about this. Fixed in https://cgit.kde.org/breeze-icons.git/commit/?id=b2f070d4c28ec47bb2978ced51df6322560916d9
Git commit 477729808ef6bf1c0fb42a4da351243b0cb1de2e by Rafael Brandmaier. Committed on 26/09/2019 at 14:45. Pushed by trickyricky into branch 'master'. Add format-text-underline-squiggle actions icons Summary: Add format-text-underline-squiggle (better name suggestions welcome!) icons as requested in https://bugs.kde.org/show_bug.cgi?id=408283 (not specifying the BUG keyword, since this doesn't add all requested icons). The curve of the underline is not great, but the best I could come up with after many tries, and I made the "U" in the 16px version 2px less tall compared to the `format-text-underline` icon, not sure if that should be changed there, too. Test Plan: The new `format-text-underline-squiggle` icons: {F7430321} For reference, the `format-text-underline` icons: {F7423453} Reviewers: #vdg, ngraham Reviewed By: #vdg, ngraham Subscribers: ndavis, ngraham, kde-frameworks-devel Tags: #frameworks Differential Revision: https://phabricator.kde.org/D24185 A +6 -0 icons-dark/actions/16/format-text-underline-squiggle.svg A +7 -0 icons-dark/actions/22/format-text-underline-squiggle.svg A +6 -0 icons/actions/16/format-text-underline-squiggle.svg A +7 -0 icons/actions/22/format-text-underline-squiggle.svg https://commits.kde.org/breeze-icons/477729808ef6bf1c0fb42a4da351243b0cb1de2e
Created attachment 122896 [details] Okular line width menu
Created attachment 122897 [details] Okular opacity menu
Created attachment 122898 [details] Okular opacity menu
Created attachment 122899 [details] Line width icon
Great, we have the first new icon! Thanks I realized that two more icons are needed. - Line width icon (see attachments "Okular line width menu" for where it will be used and "Line width icon" for how I imagine the icon more or less) - Opacity icon (see attachment "Okular opacity menu" for where it will be used)
Git commit 2b522d49a7aa5df3e176706adef6a71a0d273ef9 by Rafael Brandmaier. Committed on 06/10/2019 at 17:07. Pushed by trickyricky into branch 'master'. Add edit-line-width icons Summary: Add edit-line-width icons required for T8076. Test Plan: {F7521595} Reviewers: #vdg, ndavis Reviewed By: #vdg, ndavis Subscribers: ngraham, ndavis, kde-frameworks-devel Tags: #frameworks Differential Revision: https://phabricator.kde.org/D24412 A +6 -0 icons-dark/actions/16/edit-line-width.svg A +6 -0 icons-dark/actions/22/edit-line-width.svg A +6 -0 icons/actions/16/edit-line-width.svg A +6 -0 icons/actions/22/edit-line-width.svg https://commits.kde.org/breeze-icons/2b522d49a7aa5df3e176706adef6a71a0d273ef9
Git commit 71b9713970eb261650e64bb36b3b1d3e28bbca45 by Rafael Brandmaier. Committed on 11/10/2019 at 10:30. Pushed by trickyricky into branch 'master'. Add draw-highlight action icons Summary: This patch adds draw-highlight icons requested by Okular for D15580. I went with a style of showing the whole marker to be consistent with our other draw-* icons. The stroke is 2px thick to illustrate the broad tip of the highlighter. Test Plan: {F7547615} Reviewers: #vdg, ngraham, ndavis Reviewed By: #vdg, ngraham, ndavis Subscribers: ngraham, ndavis, kde-frameworks-devel Tags: #frameworks Differential Revision: https://phabricator.kde.org/D24493 A +6 -0 icons-dark/actions/16/draw-highlight.svg A +6 -0 icons-dark/actions/22/draw-highlight.svg A +6 -0 icons/actions/16/draw-highlight.svg A +6 -0 icons/actions/22/draw-highlight.svg https://commits.kde.org/breeze-icons/71b9713970eb261650e64bb36b3b1d3e28bbca45
Git commit b55f299b17339e7140adbb47b20c5b1513fbc2fb by Rafael Brandmaier. Committed on 13/10/2019 at 19:13. Pushed by trickyricky into branch 'master'. Add draw-arrow icons Summary: This patch adds draw-highlight icons requested by Okular for D15580. The design is based on `draw-line` with an arrowhead. I am not quite sure about the naming as there are already `draw-arrow-{up,down,forward,back}` icons that symlink to the standard arrow icons. I could not find an application where these are used. Test Plan: {F7572097} Reviewers: #vdg, ndavis Reviewed By: #vdg, ndavis Subscribers: ndavis, kde-frameworks-devel Tags: #frameworks Differential Revision: https://phabricator.kde.org/D24555 A +4 -0 icons-dark/actions/16/draw-arrow.svg A +4 -0 icons-dark/actions/22/draw-arrow.svg A +4 -0 icons/actions/16/draw-arrow.svg A +4 -0 icons/actions/22/draw-arrow.svg https://commits.kde.org/breeze-icons/b55f299b17339e7140adbb47b20c5b1513fbc2fb
Git commit 36993fdded88482048a0865a4dcc85a00eeea13a by Rafael Brandmaier. Committed on 19/10/2019 at 21:03. Pushed by trickyricky into branch 'master'. Add edit-opacity icons Summary: This patch adds edit-opacity icons requested by Okular for D15580. I'm not quite sure about the naming, and even if the Qt SVG renderer can handle this transparency. I also considered a style with a checkerboard pattern, which is the symbol for transparency e.g. in GIMP, but I felt this is not recognizable enough to most people. If you search for a opacity/transparency icon, you often find something with two overlapping circles, however I think that would be too close to our path-intersection etc. icons. I think this should be the last icon needed for https://bugs.kde.org/show_bug.cgi?id=408283, so I'm tagging this as closing that bug. FIXED-IN: 5.64 Test Plan: The new `edit-opacity` icons: {F7624384} Reviewers: #vdg, ngraham, ndavis Reviewed By: #vdg, ngraham, ndavis Subscribers: ndavis, ngraham, kde-frameworks-devel Tags: #frameworks Differential Revision: https://phabricator.kde.org/D24753 A +5 -0 icons-dark/actions/16/edit-opacity.svg A +5 -0 icons-dark/actions/22/edit-opacity.svg A +5 -0 icons/actions/16/edit-opacity.svg A +5 -0 icons/actions/22/edit-opacity.svg https://commits.kde.org/breeze-icons/36993fdded88482048a0865a4dcc85a00eeea13a