Bug 408242 - If you cut a clip with the effects turned off on the right side of the clip, the effects turn on
Summary: If you cut a clip with the effects turned off on the right side of the clip, ...
Status: RESOLVED FIXED
Alias: None
Product: kdenlive
Classification: Applications
Component: User Interface (show other bugs)
Version: 19.08.3
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Jean-Baptiste Mardelle
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-06-03 09:00 UTC by ITicDigger
Modified: 2019-11-25 21:03 UTC (History)
2 users (show)

See Also:
Latest Commit: https://invent.kde.org/kde/kdenlive/commit/a8874a4d1324d9965fde811443e429cb0fa65925
Version Fixed In:
fritzibaby: timeline_corruption+

Attachments
all effects switcher (77.26 KB, image/jpeg)
2019-11-24 23:00 UTC, Yevhen Popok 		Details
Here's demonstration of my issue (208.48 KB, image/gif)
2019-11-24 23:49 UTC, Yevhen Popok 		Details
Show Obsolete (1) View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description ITicDigger 2019-06-03 09:00:49 UTC 
STEPS TO REPRODUCE
1. Turn off any clip effects by clicking on the eye icon.
2. Cut clip

OBSERVED RESULT
Get 2 clips - left and right. On the right clip, all previously disabled effects will be turned on. 

EXPECTED RESULT
I think they should be turned off.

SOFTWARE/OS VERSIONS
UBtuStudio 18.04.1 64-bit
Appimage 19.04.1c

ADDITIONAL INFORMATION
Comment 1 Jean-Baptiste Mardelle 2019-06-03 11:45:00 UTC 
Git commit a8874a4d1324d9965fde811443e429cb0fa65925 by Jean-Baptiste Mardelle.
Committed on 03/06/2019 at 11:44.
Pushed by mardelle into branch 'Applications/19.04'.

Fix copy effect or split does not keep disabled state

M  +2    -2    src/effects/effectstack/model/effectitemmodel.cpp
M  +1    -1    src/effects/effectstack/model/effectitemmodel.hpp
M  +17   -2    src/effects/effectstack/model/effectstackmodel.cpp

https://invent.kde.org/kde/kdenlive/commit/a8874a4d1324d9965fde811443e429cb0fa65925
Comment 2 Yevhen Popok 2019-11-23 21:05:39 UTC 
I guess this problem is not fully resolved because after cut, "all effects switcher" on the right side has incorrect status (at least in Kdenlive 19.08.3)

STEPS TO REPRODUCE
1. Disable all effects of a clip (eye icon)
2. Cut a clip
3. On the right side try to re-enable all effects at once

OBSERVED RESULT
Icon show the effects are enable (eye icon is not crossed) but all effects on the list are disabled. Clicking on "all effects" button changes nothing. You have to re-enable them on by one (or delete all of them and copy from the left side).
Comment 3 emohr 2019-11-24 18:45:10 UTC 
Your step 3: "try to re-enable all effects at once" -> I have 2 effects on the same clip -> How can I enable/disable all clips at ones?
Comment 4 Yevhen Popok 2019-11-24 23:00:08 UTC 
Created attachment 124106 [details]
all effects switcher
Comment 5 Yevhen Popok 2019-11-24 23:04:43 UTC 
(In reply to emohr from comment #3)
> Your step 3: "try to re-enable all effects at once" -> I have 2 effects on
> the same clip -> How can I enable/disable all clips at ones?

I didn't say about disabling all clips. This bug is about effects status on particular clip. Added screenshot with button I'm referring to.
Comment 6 Yevhen Popok 2019-11-24 23:49:18 UTC 
Created attachment 124107 [details]
Here's demonstration of my issue
Comment 8 Yevhen Popok 2019-11-25 21:03:01 UTC 
Works for me. Thank you!