Bug 408210 - Layout problem: Playlist song times cut off
Summary: Layout problem: Playlist song times cut off
Status: RESOLVED FIXED
Alias: None
Product: Elisa
Classification: Applications
Component: general (other bugs)
Version First Reported In: 0.4.0
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: Matthieu Gallien
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-06-02 12:28 UTC by Johannes Jordan
Modified: 2019-06-06 21:29 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
screenshot shoing the glitch (412.61 KB, image/png)
2019-06-02 12:28 UTC, Johannes Jordan
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Johannes Jordan 2019-06-02 12:28:47 UTC
Created attachment 120498 [details]
screenshot shoing the glitch

SUMMARY

When the playlist is displayed in the right pane, the right-alignment of song times is off. This leads to them being displayed incomplete.


OBSERVED RESULT
The wider the window, the more the text is cut off. See screenshot for a fullscreen view.


EXPECTED RESULT
Text is perfectly right-aligned, which is, in fact, the case when the playlist is shown in the middle pane (Now Playing).


SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Archlinux with LXQt 0.14.1
KDE Plasma Version: 5.15 (unused)
KDE Frameworks Version: 5.58.0
Qt Version: 5.12.3

ADDITIONAL INFORMATION

Also happens with current git.
Comment 1 Johannes Jordan 2019-06-02 12:29:42 UTC
It seems this also affects the right-aligned icons in line with the number of tracks.
Comment 2 Nate Graham 2019-06-04 14:04:00 UTC
Does the problem go away or reduce in severity if you un-maximize the window?
Comment 3 Johannes Jordan 2019-06-04 14:05:23 UTC
The window is not maximized. Reducing the window width reduces the effect. The effect is not seen when the window has minimal width.
Comment 4 Nate Graham 2019-06-04 14:09:47 UTC
Interesting, thanks!
Comment 5 Nate Graham 2019-06-04 17:14:00 UTC
Here's a patch that should fix the issue: https://phabricator.kde.org/D21582
Comment 6 Nate Graham 2019-06-06 20:59:42 UTC
Git commit 50bbbfa301c80d83712fdd10e6328692d21e53e9 by Nate Graham.
Committed on 06/06/2019 at 20:59.
Pushed by ngraham into branch '0.4'.

Make Playlist items span full width

Summary:
Currently playlist items do not span the full width; there is a bunch of
complicated logic to determine the margins and playlist's width. This
makes the display look unbalanced and causes a subtle visual bug
(see BUG: below).

This patch resolves both issues by making playlist items visually stick to
both edges of the playlist, just like the category selector list items do.

This patch also does a bit of necessary code cleanup for the playlist states.
I tested this out quite a bit but to make sure there were no regressions but
it's possible that I missed something so more testing may be needed.

Test Plan:
Before: {F6871989}

After: {F6871988}

Reviewers: mgallien, #elisa

Reviewed By: mgallien, #elisa

Subscribers: januz

Differential Revision: https://phabricator.kde.org/D21582

M  +1    -18   src/qml/ContentView.qml
M  +5    -0    src/qml/MediaPlayListView.qml
M  +7    -3    src/qml/PlayListAlbumHeader.qml
M  +3    -2    src/qml/PlayListEntry.qml

https://commits.kde.org/elisa/50bbbfa301c80d83712fdd10e6328692d21e53e9
Comment 7 Nate Graham 2019-06-06 21:00:34 UTC
Git commit fe7d70433b624fe84320725f36aa27b2e3d2e36c by Nate Graham.
Committed on 06/06/2019 at 21:00.
Pushed by ngraham into branch 'master'.

Make Playlist items span full width

Summary:
Currently playlist items do not span the full width; there is a bunch of
complicated logic to determine the margins and playlist's width. This
makes the display look unbalanced and causes a subtle visual bug
(see BUG: below).

This patch resolves both issues by making playlist items visually stick to
both edges of the playlist, just like the category selector list items do.

This patch also does a bit of necessary code cleanup for the playlist states.
I tested this out quite a bit but to make sure there were no regressions but
it's possible that I missed something so more testing may be needed.

Test Plan:
Before: {F6871989}

After: {F6871988}

Reviewers: mgallien, #elisa

Reviewed By: mgallien, #elisa

Subscribers: januz

Differential Revision: https://phabricator.kde.org/D21582

M  +1    -18   src/qml/ContentView.qml
M  +5    -0    src/qml/MediaPlayListView.qml
M  +7    -3    src/qml/PlayListAlbumHeader.qml
M  +3    -2    src/qml/PlayListEntry.qml

https://commits.kde.org/elisa/fe7d70433b624fe84320725f36aa27b2e3d2e36c
Comment 8 Johannes Jordan 2019-06-06 21:22:46 UTC
Nate, your attention to these details is very much appreciated!

It looks/works as expected now.
Comment 9 Nate Graham 2019-06-06 21:29:34 UTC
Excellent!