Bug 408204 - Layer stack behavior changed since 4.1.7
Summary: Layer stack behavior changed since 4.1.7
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Layer Stack (show other bugs)
Version: git master (please specify the git hash!)
Platform: Appimage Linux
: NOR normal
Target Milestone: ---
Assignee: vanyossi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-06-02 06:12 UTC by Dmitrii Utkin
Modified: 2019-06-02 22:51 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Screen record of the changed behavior (4.3.0 git) (271.30 KB, video/mp4)
2019-06-02 06:28 UTC, Dmitrii Utkin
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitrii Utkin 2019-06-02 06:12:27 UTC
When upgrading from 4.1.7 to 4.2.0 and 4.3.0 (git) I faced with two issues with layer stack. It's likely to be in the same piece of the code and because of that I didn't fill two bugs.


First is related to clicks to thumbnail. In 4.1.7 when you click to group layer thumbnail it gets folded and unfolded, which is convenient and I always used this. Now (since 4.2.0) you can only fold/unfold layer by clicking the very small area to the right of thumbnail. It's hard to click to it with the pen actually. 


The second bug (4.3.0 git master) is related to layer creating and traversing layer box by the keyboard. When you do one of the actions, below, the layer group is expecting to be unfolded (as in 4.1.7), but it doesn't:
1. surround a layer by group (Ctrl+G)
2. create layer mask
3. navigating with Page Up/Page Down.


Guess the first bug was introduced due to some change in logic of layer selection, maybe adding the feature to select non-transparent layer area by <Modifier>+Click to thumbnail, and some related effect of this was fixed in e775a0e82501633b5769e17263fa7ad5d036a29e but the thumbnail-click behavior wasn't restored.


I believe that the second bug is introduced in c475619ef738854bf40d6b6844510c13da1357dc, when the last "else" block was added. the "setCurrentIndex" is never called in this case and because of that automating unfolding doesn't work. (Also the code analyzer is claiming about misusing the "hasCorrectModifier" and "action" variables).


I will try to fix it on free time.
Comment 1 Dmitrii Utkin 2019-06-02 06:28:19 UTC
Created attachment 120492 [details]
Screen record of the changed behavior (4.3.0 git)
Comment 2 Halla Rempt 2019-06-02 06:55:59 UTC
Please go ahead :-)
Comment 3 Dmitrii Utkin 2019-06-02 07:48:17 UTC
Here is the MR: https://invent.kde.org/kde/krita/merge_requests/35

By some reason when I use MR template provided the label "Needs Review" is not set, while template contains "/label ...". Probably, because I don't have permissions to set labels.. 

And please tell me, who is responsible to close issues here? I mean shall I changed issue status to RESOLVED once it gets merged to the master?
Comment 4 vanyossi 2019-06-02 22:43:56 UTC
Hi, I reviewed you revert but no, that will not revert the unfolding behaviour. But if it is indeed a bug I can restore it.

The unfolding was "removed" when click on thumbnail selection was introduced.

:)
Comment 5 vanyossi 2019-06-02 22:51:29 UTC
Merged the patch and marking as fixed