Bug 408192 - Inactive window effects do not apply to tab bar
Summary: Inactive window effects do not apply to tab bar
Status: RESOLVED FIXED
Alias: None
Product: kate
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: KWrite Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-06-01 21:48 UTC by Nate Graham
Modified: 2020-10-30 00:47 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 20.08


Attachments
Tab bar text does not fade along with everything else (690.73 KB, image/gif)
2019-06-01 21:48 UTC, Nate Graham
Details
attachment-16283-0.html (1.08 KB, text/html)
2019-06-23 17:28 UTC, tcanabrava
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2019-06-01 21:48:04 UTC
Created attachment 120487 [details]
Tab bar text does not fade along with everything else

STEPS TO REPRODUCE
1. Go to System Settings > Colors
2. Edit the current color scheme
3. Check "Apply Inactive window effects"
4. Go to the "inactive" tab, change "Contrast" to "Fade" and move the slider a ways to the right
5. Open Kate with multiple tabs
6. Make the window inactive


OBSERVED RESULT
The tabs' text does not fade when the window becomes inactive


EXPECTED RESULT
The text should fade


ADDITIONAL INFORMATION
Discovered while working on https://phabricator.kde.org/T10201


SOFTWARE/OS VERSIONS
Everything from git master
Comment 1 Dominik Haumann 2019-06-23 06:33:06 UTC
Implemented in katetabbutton.cpp:
https://github.com/KDE/kate/blob/master/kate/katetabbutton.cpp#L122
Comment 2 Nate Graham 2019-06-23 10:02:58 UTC
Yet another reason to port to a native QTabBar (Bug 385520) :)
Comment 3 Dominik Haumann 2019-06-23 16:53:45 UTC
(sidenote: I am very much surprised by the fact that so many believe porting to QTabBar will resolve all the tabbar issues: it will not. In fact am rather sure that we will get just as many compliments as we have now)
Comment 4 tcanabrava 2019-06-23 17:28:30 UTC
Created attachment 121103 [details]
attachment-16283-0.html

Not all but quite a few. I have a wip in progress already and it will
reduce the codebase and make a few things less custom looking.

Em dom, 23 de jun de 2019 às 18:53, Dominik Haumann <
bugzilla_noreply@kde.org> escreveu:

> https://bugs.kde.org/show_bug.cgi?id=408192
>
> --- Comment #3 from Dominik Haumann <dhaumann@kde.org> ---
> (sidenote: I am very much surprised by the fact that so many believe
> porting to
> QTabBar will resolve all the tabbar issues: it will not. In fact am rather
> sure
> that we will get just as many compliments as we have now)
>
> --
> You are receiving this mail because:
> You are on the CC list for the bug.
Comment 5 Justin Zobel 2020-10-30 00:29:25 UTC
I'm unable to reproduce this on kate from git master, can you please confirm this issue still exists?
Comment 6 Nate Graham 2020-10-30 00:47:34 UTC
Yep, fixed now that the tab bar is using standard widgets.