Bug 408186 - Extracting archive into directory with 'tab' in the name.
Summary: Extracting archive into directory with 'tab' in the name.
Status: RESOLVED FIXED
Alias: None
Product: ark
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: Elvis Angelaccio
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-06-01 19:04 UTC by J.D
Modified: 2020-10-18 09:51 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In: 20.11.80


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description J.D 2019-06-01 19:04:38 UTC
By 'tab' I mean \t. E.g. 'ddd		ccc'

Extracting archive into directory with \t in its name by submenu 'Extract to' - extracts into the directory with archive. 
Extracting by drug-and-drop into a dir with \t in its name - archive gets extracted into ~/

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Linux lom 5.1.4-arch1-1-ARCH x86_64 GNU/Linux
KDE Frameworks Version: 5.58.0
Qt Version: 5.12.3
Comment 1 Nate Graham 2019-06-05 14:50:36 UTC
How are you extracting it? With the context menu's "Extract > Extract archive here" command?
Comment 2 J.D 2019-06-05 21:10:28 UTC
Extracting by context menu "Extract > Extract archive to..."- extracts into the directory with archive ignoring chosen destination. 
Extracting by drug-and-drop - archive gets extracted into ~/
Comment 3 Nate Graham 2019-06-05 21:23:46 UTC
Thanks!
Comment 4 Elvis Angelaccio 2019-06-05 21:36:43 UTC
Moving to Ark which is what provides the Extract menu.
Comment 5 Bug Janitor Service 2020-10-12 14:46:57 UTC
A possibly relevant merge request was started @ https://invent.kde.org/utilities/ark/-/merge_requests/14
Comment 6 Elvis Angelaccio 2020-10-18 09:51:40 UTC
Git commit 108ade3b57f1eca792a54843e9c646eb1322a7ef by Elvis Angelaccio, on behalf of Jan Paul Batrina.
Committed on 18/10/2020 at 09:51.
Pushed by elvisangelaccio into branch 'master'.

Fix extraction to directories with unicode names when using the Extract file menu

Before this patch, BatchExtract::setDirectory() would ignore directories whose path
contains a tab or an emoji, because QUrl::toDisplayString() returns a percent-encoded name
(regardless of FormattingOption) which does not get percent-decoded.
(see https://stackoverflow.com/questions/24343582/convert-qurl-with-percent-encoding-into-string/24394362#24394362)

We now use QUrl::toLocalFile() instead, which does not percent-encode the name, and we warn the user
if the destination is not local (which is not supported by Ark).

This bug was only present on the extract file menu (via dolphin context menu).
FIXED-IN: 20.11.80

M  +22   -11   app/batchextract.cpp

https://invent.kde.org/utilities/ark/commit/108ade3b57f1eca792a54843e9c646eb1322a7ef