Bug 408171 - Filter layer properties layer name textbox not correctly themed in Windows
Summary: Filter layer properties layer name textbox not correctly themed in Windows
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Usability (show other bugs)
Version: 4.2.0
Platform: Microsoft Windows Microsoft Windows
: NOR minor
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-06-01 06:58 UTC by Carl Olsson
Modified: 2019-06-13 06:33 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Demonstrative image (5.54 KB, image/png)
2019-06-01 06:59 UTC, Carl Olsson
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Carl Olsson 2019-06-01 06:58:45 UTC
SUMMARY
The layer name textbox in the filter layer properties dialog is not correctly themed.
It appears rendered in windows default theme while other layer properties dialogs theme it as expected following the rest of the Krita theme.

STEPS TO REPRODUCE
1. Select Krita dark theme
2. Open filter layer properties dialog

OBSERVED RESULT
Layer name textbox is seemingly rendered using default windows theme (light with blue focus highlight).

EXPECTED RESULT
Layer name textbox themed in accordance with the rest of Krita.

SOFTWARE/OS VERSIONS
Windows: Microsoft Windows 10 Pro 10.0.17763 Build 17763
Comment 1 Carl Olsson 2019-06-01 06:59:44 UTC
Created attachment 120469 [details]
Demonstrative image
Comment 2 Carl Olsson 2019-06-01 17:55:49 UTC
Checked under Linux with current git build and seems to be themed correctly there.
So I guess it's a Windows specific issue.
Comment 3 Halla Rempt 2019-06-12 14:41:46 UTC
Git commit 68135ff05e583e855aafcd5758c1fc049ece9d3a by Boudewijn Rempt.
Committed on 12/06/2019 at 14:41.
Pushed by rempt into branch 'master'.

Remove the last use of KLineEdit
BACKPORT:krita/4.2

M  +2    -3    libs/ui/dialogs/kis_dlg_adj_layer_props.cc

https://invent.kde.org/kde/krita/commit/68135ff05e583e855aafcd5758c1fc049ece9d3a
Comment 4 Halla Rempt 2019-06-12 14:42:15 UTC
Well spotted, this was the last place where klineedit was still used :-)
Comment 5 Halla Rempt 2019-06-13 06:33:14 UTC
Git commit edd51c6b2511583f0b5e3a97a0494484c94e298b by Boudewijn Rempt.
Committed on 13/06/2019 at 05:59.
Pushed by rempt into branch 'krita/4.2'.

Remove the last use of KLineEdit
BACKPORT:krita/4.2
(cherry picked from commit 68135ff05e583e855aafcd5758c1fc049ece9d3a)

M  +2    -3    libs/ui/dialogs/kis_dlg_adj_layer_props.cc

https://invent.kde.org/kde/krita/commit/edd51c6b2511583f0b5e3a97a0494484c94e298b