Bug 408097 - Clone Tool leaves brush mark when trying to sample new area
Summary: Clone Tool leaves brush mark when trying to sample new area
Status: REPORTED
Alias: None
Product: krita
Classification: Applications
Component: Brush engines (other bugs)
Version First Reported In: 4.2.0
Platform: Microsoft Windows Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords: triaged
Depends on:
Blocks:
 
Reported: 2019-05-30 08:16 UTC by winterhawk28
Modified: 2022-08-10 08:47 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description winterhawk28 2019-05-30 08:16:29 UTC
The clone stamp tool leaves a brush mark whenever you Ctrl+LMB (or Ctrl+Pen Touch) to anchor the clone sampling point to a new area. 


STEPS TO REPRODUCE
1. Make sure that the clone sampling circle is hovering over something that would leave a visible mark if cloned to the new spot.
2. Using Ctrl+Left mouse click (easier to see that way, since pressure sensitivity on a pen tablet may make it harder to see the mark), sample a new area.
3. This will anchor the sampler to the new area, but also leave a clone mark sampled from the area the sampler was at at the time you clicked.


For now, there is a workaround where you can press Ctrl+Alt instead of Ctrl, to sample a new area, and this will not leave a brush mark.
Comment 1 Halla Rempt 2019-06-21 11:36:56 UTC
I must be doing something wrong, because I cannot reproduce this :-(
Comment 2 vanyossi 2019-06-25 03:53:15 UTC
I cannot reproduce this bug. @winterhawk28, Is this still an issue on latest krita?
Comment 3 winterhawk28 2019-06-25 12:28:30 UTC
(In reply to vanyossi from comment #2)
> I cannot reproduce this bug. @winterhawk28, Is this still an issue on latest
> krita?

I think I've figured out the problem (and possibly how to reproduce it reliably).

It was triggered by my Krita settings. 

I deleted my Krita settings by moving the entire folder away, and the problem was gone after restarting Krita. After restoring my old settings by moving the folder back, the problem was back again. 

I figured out that the problem was that my old settings was missing the "Ctrl+Left Button" keybind under "Canvas Input Settings > Alternate Invocation", By default, when you start a fresh copy of Krita with fresh default settings, "Ctrl + Left Button" is set to "Pick Foreground Color from Merged Image".

You can reproduce the problem I was having by going into "Canvas Input Settings > Alternate Invocation" and deleting the "Ctrl+Left Button" keybind. Since it is a restricted default setting and won't let you delete it, I managed to deleted it by modifying it (such as changing the action from "Pick Foreground Color" to "Primary") and then it became deletable. Once that is gone, the Clone Tool will start glitching out the way I described. 

But I was able to get the Clone Tool working properly again by manually adding the "Ctrl+Left Button" keybind back in and setting the Action to "Pick Foreground Color from Merged Image" ("from Current Layer" works also).
Comment 4 Halla Rempt 2019-06-25 12:42:50 UTC
Ah... I'm not really sure what we can do to prevent this, to be honest.
Comment 5 Tiar 2021-05-19 00:48:21 UTC
So, if I understand correctly, it seems to work on Ivan's and Halla's systems only because the shortcut is used for two things: Clone Tool picking and color picking (which disabled making marks)? And if you remove the second one, then it starts painting, because the color picker won't be there anymore to prevent that?