Bug 408052 - Auto precision does not seem to update on brush size Change
Summary: Auto precision does not seem to update on brush size Change
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Brush engines (show other bugs)
Version: git master (please specify the git hash!)
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: vanyossi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-05-29 04:43 UTC by vanyossi
Modified: 2019-08-21 15:56 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description vanyossi 2019-05-29 04:43:21 UTC
While fixing a bug I noticed the only place autoprecision is calculated is when checking the Auto precision checkbox. Resizing the brush in any way does not update precision automagically.
Comment 1 Halla Rempt 2019-05-29 07:02:16 UTC
Oops, that would be pretty bad. Are you totally sure about this?
Comment 2 vanyossi 2019-07-19 02:43:49 UTC
I can confirm this does indeed happen. Precision level is only ever updated when the "auto" checkbox is toggled, setAutoPrecision () is called, in no other situation the set setAutoPrecision is called.
Comment 3 vanyossi 2019-08-21 15:56:19 UTC
Git commit f54aaece8453b7620bb49c23fd98df2becae436c by Ivan Yossi.
Committed on 21/08/2019 at 15:56.
Pushed by ivany into branch 'master'.

Fix update auto precision level on brush resize.

This commit adds the proper call to update precision on resize during
dab cache fetch. It also adds signals to update the String in Gui if the
user changes Size of brush while auto precision is activated.

M  +1    -1    plugins/paintops/libpaintop/kis_brush_chooser.h
M  +36   -7    plugins/paintops/libpaintop/kis_brush_selection_widget.cpp
M  +2    -0    plugins/paintops/libpaintop/kis_brush_selection_widget.h
M  +7    -1    plugins/paintops/libpaintop/kis_dab_cache_base.cpp
M  +1    -0    plugins/paintops/libpaintop/kis_text_brush_chooser.cpp
M  +1    -0    plugins/paintops/libpaintop/kis_text_brush_chooser.h

https://invent.kde.org/kde/krita/commit/f54aaece8453b7620bb49c23fd98df2becae436c