Bug 407946 - Duplicates search should perform the search automatically
Summary: Duplicates search should perform the search automatically
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Searches-Similarity (show other bugs)
Version: 6.2.0
Platform: Appimage Linux
: NOR minor
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-05-25 16:10 UTC by MarcP
Modified: 2019-05-25 20:20 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 6.2.0
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description MarcP 2019-05-25 16:10:54 UTC
SUMMARY

Performing a duplicate search is quite cumbersome at the moment. 

First, you must right click the Album or Tag and select "Find Duplicates...". Digikam then just opens the Similarity panel with the Album or Tag preselected on the dropdown list, but does nothing.

The user then needs to select the appropriate "Restrict to" option ("Albums but no tags, or "Tags but not albums"), otherwise the search won't work, and finally click on the "Find duplicates" button.

Moreover, that panel will show the results of the last similarity search performed by the user (even from the "Image" tab). I think old results should be cleared up before performing the new search.

STEPS TO REPRODUCE
1. Right click on any Album or Tag.
2. Click on "Find duplicates...".

OBSERVED RESULT
The Similarity panel opens. Said Album/Tag is pre-selected on the list.
If a previous search had been performed, the results are still there.

EXPECTED RESULT
The search is performed automatically and results (duplicated pictures) are shown.

SOFTWARE/OS VERSIONS
Ubuntu 18.04 with Gnome
digikam-6.2.0-git-20190522T104638-qtwebkit-x86-64.appimage
Comment 1 Maik Qualmann 2019-05-25 16:23:25 UTC
What do you think about the ComboBox at top, ie "only selected tabs, albums but not tags", etc. Is this helpful? Mario installed it, because the album selection was not so clear, but there were corrections in the meantime. I tend to remove this selection...

Maik
Comment 2 MarcP 2019-05-25 16:30:32 UTC
I mean, it allows for flexibility in the search, which is great, but it's not user friendly at all.

I would personally put that Combobox in an "Advanced" section, and by default search only in Albums or Tags, based on which tab is selected at that moment. 

Same with the "Similarity range" and "Restriction" options.
Comment 3 MarcP 2019-05-25 16:34:54 UTC
Oh, and I forgot, I would perform the fingerprint update on the go, as new files are imported into Digikam. At least if the main fingerprint update has already been performed manually. (Maybe an option in the main settings, to enable o disable automatic fingerprints?).

Otherwise the user needs to remember to regularly update the fingerprints by going to that panel an clicking that button. (And the same same applies to face detection/recognition, but that's another topic).
Comment 4 Maik Qualmann 2019-05-25 20:20:04 UTC
Git commit 672daf431b8c0ac79a843ff05824c0449fd0a308 by Maik Qualmann.
Committed on 25/05/2019 at 20:18.
Pushed by mqualmann into branch 'master'.

perform auto duplicates search an set settings
fix some search albums views
FIXED-IN: 6.2.0

M  +2    -1    NEWS
M  +1    -1    core/app/views/sidebar/leftsidebarwidgets.cpp
M  +6    -2    core/libs/album/manager/albummanager.h
M  +8    -0    core/libs/album/manager/albummanager_album.cpp
M  +32   -1    core/utilities/fuzzysearch/findduplicatesview.cpp
M  +1    -0    core/utilities/fuzzysearch/findduplicatesview.h
M  +7    -7    core/utilities/fuzzysearch/fuzzysearchview.cpp
M  +2    -2    core/utilities/geolocation/mapsearches/gpssearchview.cpp
M  +1    -1    core/utilities/searchwindow/searchmodificationhelper.cpp

https://invent.kde.org/kde/digikam/commit/672daf431b8c0ac79a843ff05824c0449fd0a308