Created attachment 120310 [details] screenshot SUMMARY As we can see in the screenshot of elisa 0.4 on Arch Linux, folder names are misaligned in "Files" view. STEPS TO REPRODUCE 1. open elisa 2. click "Files" in the left side 3. EXPECTED RESULT folder names are aligned correctly. SOFTWARE/OS VERSIONS Operating System: Arch Linux KDE Plasma Version: 5.15.5 KDE Frameworks Version: 5.58.0 Qt Version: 5.12.3
Looks like I forgot to update the file browser delegates when I did https://cgit.kde.org/elisa.git/commit/?id=761e3af65347072f12b770529a5effb6b39b6e58
Here's a patch: https://phabricator.kde.org/D21469
Git commit abd7c706965e1b10cd1fd227b828ae1ddb37fcd7 by Nate Graham. Committed on 30/05/2019 at 16:13. Pushed by ngraham into branch '0.4'. Port GridBrowser Delegate UI changes to FileBrowserDelegate too Summary: When I did D20581, I forgot to do the File Browser view too. This patch ports the UI changes done in D20581. Side note: it feels like these two delegates should really be using the same paramaterized components rather than mostly sharing the same code which must then be kept in sync. This one also has no test coverage; even more reason to move towards using the GridBrowserDelegate for both. Test Plan: Tests still pass; UI now looks the same as the grid items in other views {F6857184} Reviewers: mgallien, #elisa Reviewed By: mgallien, #elisa Differential Revision: https://phabricator.kde.org/D21469 M +51 -56 src/qml/FileBrowserDelegate.qml https://commits.kde.org/elisa/abd7c706965e1b10cd1fd227b828ae1ddb37fcd7