Bug 407915 - The "Custom character color" option is required in "Cursor" tab
Summary: The "Custom character color" option is required in "Cursor" tab
Status: RESOLVED FIXED
Alias: None
Product: konsole
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR wishlist
Target Milestone: ---
Assignee: Konsole Developer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-05-24 18:31 UTC by Manuel
Modified: 2020-02-11 16:45 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In: 20.04


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Manuel 2019-05-24 18:31:13 UTC
SUMMARY
---------------

The "Custom character color" option is required.

When you go to "Edit current profile" -> "Appearance" -> "Cursor" -> "Color" you can choose between "Match current character" or "Custom cursor color"

If you choose "Custom color cursor" there should be the possibility to also choose the color of the character under the cursor.

Without this option it is impossible to have configurations such as:

Dark background, clear letter, clear cursor

or:

Light background, dark letter, dark cursor.

Because choosing "Custom color cursor" takes the color of the character under the cursor of the rest of the characters.

This makes this option quite useless, because it will almost always produce very low contrast results. Either the cursor will have little contrast to the background, or the cursor will have little contrast to the character under the cursor itself.

STEPS TO REPRODUCE
--------------------------------------

1. Go to "Edit current profile" -> "Appearance"
2. In "Color scheme & font" tab choose a scheme with dark background (Breeze, for example)
3. Then go to "Cursor" tab and choose "Block" for "Shape" option
4. Finally go to "Color" option, choose "Custom color cursor" and set it to yellow (or any light color)

OBSERVED RESULT

The character under the cursor has very low contrast to the cursor. It is not possible to choose a cursor color that contrasts simultaneously with the background and with the character under the cursor.


EXPECTED RESULT
------------------------------

There should be an option that allows you to customize the color of the character under the cursor.

SOFTWARE/OS VERSIONS
---------------------------------------

Windows: 
macOS: 
Linux/KDE Plasma: Arch Linux, kernel 5.1.4
(available in About System)
KDE Plasma Version: 5.15.5
KDE Frameworks Version: 5.58.0
Qt Version: 5.12.3
Comment 1 Christoph Feck 2019-06-14 10:55:29 UTC
Cannot reproduce.

There is a color selector next to the radio button. Clicking it opens a color dialog, and selecting a color there also works and is applied to the cursor.
Comment 2 Christoph Feck 2019-06-14 11:00:15 UTC
Ignore the previous comment.

Reporter needs two colors configurable: background and foreground color.

The current option is not useless, because it works for line-shaped cursors. Marking as a wish.
Comment 3 Arthur Kasimov 2020-02-11 16:45:02 UTC
Git commit a7f23d216e8020020e9061b058a44d48b39f9f08 by Arthur Kasimov.
Committed on 10/02/2020 at 20:57.
Pushed by hindenburg into branch 'master'.

Add an option to set the custom color of text under the cursor

Current version of Konsole allows to select the custom color of the
cursor (Settings -> Edit Current Profile -> Appearance -> Cursor ->
Custom cursor color). This works well for I-Beam and Underline cursor
shapes. But for block-shaped cursors the text under the cursor is often
hard to read, e.g. bright text under the bright cursor or dark text
under the dark cursor.

This patch adds an ability to select the custom color of the character
under the cursor. The character uses this color only when the cursor
shape is Block and Konsole window is focused. Otherwise the character
uses its foreground color as usual.
FIXED-IN: 20.04

M  +72   -31   src/EditProfileAppearancePage.ui
M  +11   -6    src/EditProfileDialog.cpp
M  +1    -0    src/EditProfileDialog.h
M  +3    -1    src/Profile.cpp
M  +12   -1    src/Profile.h
M  +23   -17   src/TerminalDisplay.cpp
M  +21   -2    src/TerminalDisplay.h
M  +2    -0    src/autotests/ProfileTest.cpp

https://invent.kde.org/kde/konsole/commit/a7f23d216e8020020e9061b058a44d48b39f9f08
Comment 4 Arthur Kasimov 2020-02-11 16:45:06 UTC
Git commit a7f23d216e8020020e9061b058a44d48b39f9f08 by Arthur Kasimov.
Committed on 10/02/2020 at 20:57.
Pushed by scmsync into branch 'master'.

Add an option to set the custom color of text under the cursor

Current version of Konsole allows to select the custom color of the
cursor (Settings -> Edit Current Profile -> Appearance -> Cursor ->
Custom cursor color). This works well for I-Beam and Underline cursor
shapes. But for block-shaped cursors the text under the cursor is often
hard to read, e.g. bright text under the bright cursor or dark text
under the dark cursor.

This patch adds an ability to select the custom color of the character
under the cursor. The character uses this color only when the cursor
shape is Block and Konsole window is focused. Otherwise the character
uses its foreground color as usual.
FIXED-IN: 20.04

M  +72   -31   src/EditProfileAppearancePage.ui
M  +11   -6    src/EditProfileDialog.cpp
M  +1    -0    src/EditProfileDialog.h
M  +3    -1    src/Profile.cpp
M  +12   -1    src/Profile.h
M  +23   -17   src/TerminalDisplay.cpp
M  +21   -2    src/TerminalDisplay.h
M  +2    -0    src/autotests/ProfileTest.cpp

https://commits.kde.org/konsole/a7f23d216e8020020e9061b058a44d48b39f9f08