Bug 407801 - When set to horizontal and multiple rows, the color history fils columns first instead of rows.
Summary: When set to horizontal and multiple rows, the color history fils columns firs...
Status: REPORTED
Alias: None
Product: krita
Classification: Applications
Component: Color Selectors (show other bugs)
Version: git master (please specify the git hash!)
Platform: Arch Linux Linux
: NOR wishlist
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-05-21 14:52 UTC by Storm Engineer
Modified: 2020-10-15 13:16 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Storm Engineer 2019-05-21 14:52:00 UTC 
When recent colors for the color selector is set to horizontal, and more than one rows, it will be populated top to bottom and then left to right, instead of the other way around, which would make more sense.


OBSERVED RESULT

With two rows, the colors are populated as:
1 3 5 7
2 4 6


EXPECTED RESULT

It should be:
1 2 3 4 5
6 7


SOFTWARE/OS VERSIONS

Krita

 Version: 4.2.0-beta (git fb226d0)
 Languages: en_US
 Hidpi: false

Qt

  Version (compiled): 5.12.3
  Version (loaded): 5.12.3

OS Information

  Build ABI: x86_64-little_endian-lp64
  Build CPU: x86_64
  CPU: x86_64
  Kernel Type: linux
  Kernel Version: 5.0.13-arch1-1-ARCH
  Pretty Productname: Arch Linux
  Product Type: arch
  Product Version: unknown
Comment 1 wolthera 2019-09-21 15:54:24 UTC 
setting this to wishlist.
Comment 2 Shubham Jain 2020-10-14 10:05:17 UTC 
I tried to reproduce this bug and when the color selector is set to vertical and column is greater than one then also it gets populated left to right and then top to bottom and not the other way.

So, is this really a bug because then we have to look at both vertical color selector and horizontal color selector.
Comment 3 Halla Rempt 2020-10-15 12:37:19 UTC 
color history, not color selector...
Comment 4 Lynx3d 2020-10-15 13:16:47 UTC 
I recently looked into this while working on https://phabricator.kde.org/T13509 but there is a catch:

The list size of Color History/Colors from Image is fixed and there is no dynamic wrapping. Say you configured 40 patches in 2 rows, but only 10 per row fit into the current docker size, you'd see 1-10 + 21-30 while 11-20 and 31-40 would need scrolling, and enabling scrolling is optional even.

We could do dynamic wrapping of course, but then scrolling would have to switch from horizontal with one patch row to vertical with multiple rows, I'm not sure if everyone would like it that way. Unless of course it becomes yet another option...