Bug 407798 - Kdenlive crashes after loading a file with 'invalid transitions'
Summary: Kdenlive crashes after loading a file with 'invalid transitions'
Status: RESOLVED FIXED
Alias: None
Product: kdenlive
Classification: Applications
Component: Effects & Transitions (show other bugs)
Version: 19.04.1
Platform: Manjaro Linux
: NOR crash
Target Milestone: ---
Assignee: Vincent PINON
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-05-21 13:30 UTC by Brett
Modified: 2020-07-25 12:39 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 20.08
fritzibaby: Brainstorm+


Attachments
kdenlive file with invalid transition that causes crash (47.41 KB, application/x-kdenlive)
2019-05-21 13:30 UTC, Brett
Details
corrupt file (10.22 KB, image/png)
2020-07-25 12:38 UTC, emohr
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Brett 2019-05-21 13:30:36 UTC
Created attachment 120221 [details]
kdenlive file with invalid transition that causes crash

SUMMARY
I was working on a project that now won't open anymore due to 'invalid transitions'. There is no way to open a kdenlive project without disabling transitions, so the program crashes.

STEPS TO REPRODUCE
1. Open the Kdenlive attached file
2. 
3. 

OBSERVED RESULT
Error message regarding invalid transition on track 5 and then crash

EXPECTED RESULT
Kdenlive removes the invalid transition without crashing

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: Manjaro Linux
(available in About System)
KDE Plasma Version: 4.15
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
Comment 1 emohr 2019-05-22 17:41:06 UTC
Thank you for reporting. Confirmed.
Opened issue: https://invent.kde.org/kde/kdenlive/issues/194
Comment 2 Brett 2019-05-22 19:33:38 UTC
Looks good. By the way, in the future if I find another bug should I open an issue directly on GitLab instead of posting on this forum?
Comment 3 emohr 2019-05-23 10:38:13 UTC
Please post here in the bugtracker. 
I make some triage (test on Windows and Linux) and make a crashlog if needed. So the devs see in Gitlab only the proved ones and it makes Gitlab more neat.
Comment 4 Brett 2019-05-23 14:02:20 UTC
OK sounds good!
Comment 5 Jean-Baptiste Mardelle 2019-05-24 10:31:13 UTC
Git commit 6f1e61c6930cb5342b091c0b3c62a3e697b7d932 by Jean-Baptiste Mardelle.
Committed on 24/05/2019 at 10:30.
Pushed by mardelle into branch 'Applications/19.04'.

Detect corrupted project files on opening, propose to open backup

M  +26   -4    src/project/projectmanager.cpp
M  +2    -2    src/project/projectmanager.h

https://invent.kde.org/kde/kdenlive/commit/6f1e61c6930cb5342b091c0b3c62a3e697b7d932
Comment 6 Jean-Baptiste Mardelle 2019-05-24 10:34:51 UTC
Thanks for your report. In fact the attached project file is seriously corrupted. All timeline information is missing. I only saw this case once but was never able to reproduce. I have now pushed a patch that checks for such cases and proposes to open a previous autosave backup as a workaround.

Do you have any idea what you did just before saving the file ?
Comment 7 Jean-Baptiste Mardelle 2019-05-24 11:00:20 UTC
Git commit 1ca29700b03ab68ed9c7194dc6428295bd045abd by Jean-Baptiste Mardelle.
Committed on 24/05/2019 at 10:59.
Pushed by mardelle into branch 'Applications/19.04'.

Prevent saving corrupted file (with no tracks).

M  +16   -8    src/doc/kdenlivedoc.cpp
M  +4    -0    src/mainwindow.cpp

https://invent.kde.org/kde/kdenlive/commit/1ca29700b03ab68ed9c7194dc6428295bd045abd
Comment 8 emohr 2020-07-25 12:38:48 UTC
Created attachment 130390 [details]
corrupt file

Tested with daily build. I get the attached message.

I'm closing this bug as it is no crash anymore. With 20.08 such corrupt file should be solved as well.

If it still appears in the latest version, please feel free to re-open it and update the affected version number.