Bug 407790 - Misleading cmake message if building without vlc
Summary: Misleading cmake message if building without vlc
Status: RESOLVED FIXED
Alias: None
Product: Elisa
Classification: Applications
Component: general (show other bugs)
Version: 0.4.0
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Matthieu Gallien
URL:
Keywords:
: 407864 (view as bug list)
Depends on:
Blocks:
 
Reported: 2019-05-21 08:57 UTC by Antonio Rojas
Modified: 2019-05-23 11:48 UTC (History)
1 user (show)

See Also:
Latest Commit: https://commits.kde.org/elisa/e23fdcb93a3c768ecb514ffa030dc2e7fcec8e43
Version Fixed In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Antonio Rojas 2019-05-21 08:57:52 UTC 
SUMMARY
If you build elisa 0.4 without vlc you get a cmake message:

 * LIBVLC, libvlc allows to play music in Elisa, <https://www.videolan.org/vlc/libvlc.html>

This wrongly hints that elisa will not play music without it. I just found out by a user bug report that qtmultimedia is still supported.
Comment 1 Matthieu Gallien 2019-05-21 09:24:09 UTC 
Thanks for the report. I will clarify the message.
Comment 2 Matthieu Gallien 2019-05-21 15:25:16 UTC 
https://phabricator.kde.org/D21318 is open for review
Comment 3 Matthieu Gallien 2019-05-22 15:26:46 UTC 
Git commit e23fdcb93a3c768ecb514ffa030dc2e7fcec8e43 by Matthieu Gallien.
Committed on 22/05/2019 at 15:26.
Pushed by mgallien into branch '0.4'.

improve wording of description of libvlc dependency

Summary:
Makes the description printed by cmake easier to understand

Reviewers: #elisa, arojas, ngraham

Reviewed By: #elisa, arojas, ngraham

Subscribers: ngraham

Differential Revision: https://phabricator.kde.org/D21318

M  +1    -1    CMakeLists.txt

https://commits.kde.org/elisa/e23fdcb93a3c768ecb514ffa030dc2e7fcec8e43
Comment 4 Antonio Rojas 2019-05-23 11:48:33 UTC 
*** Bug 407864 has been marked as a duplicate of this bug. ***