Bug 407709 - List of excluded folders does not occupy all available space
Summary: List of excluded folders does not occupy all available space
Alias: None
Product: systemsettings
Classification: Applications
Component: kcm_baloo (show other bugs)
Version: 5.15.90
Platform: Archlinux Linux
: NOR minor (vote)
Target Milestone: ---
Assignee: baloo-bugs-null
Keywords: junior-jobs, usability
Depends on:
Reported: 2019-05-19 05:38 UTC by Kishore Gopalakrishnan
Modified: 2019-05-29 15:45 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.16.0

Screenshot of KCM (55.26 KB, image/png)
2019-05-19 05:38 UTC, Kishore Gopalakrishnan

Note You need to log in before you can comment on or make changes to this bug.
Description Kishore Gopalakrishnan 2019-05-19 05:38:13 UTC
Created attachment 120179 [details]
Screenshot of KCM

If we open the baloo KCM, it shows a list of excluded folders (attached screenshot). This list occupies only a small amount of the available space, and the rest of the window is left empty. Since there are not many other items in this particular KCM, it would be better to occupy the entire available vertical space instead of displaying it in a very small area which requires a lot of scrolling to view all the excluded folders.

Linux distribution: Arch Linux
KDE Plasma Version: 5.15.90
KDE Frameworks Version: 5.58.0
Qt Version: 5.13.0
Comment 1 Nate Graham 2019-05-29 15:45:10 UTC
Git commit 943140d368f506ed4098e28a1178ea1b11fc9081 by Nate Graham, on behalf of Kishore Gopalakrishnan.
Committed on 29/05/2019 at 15:25.
Pushed by ngraham into branch 'Plasma/5.16'.

Allow 'Exclude folders' section in Baloo KCM to fill window

Initially, there was a spacer which took up a significant amount of space at the bottom of the window without any apprent justification.

I removed a spacer to allow the folder list to occupy the available space.

It seems like it was added intentionally, so I'm not sure if removing it breaks something. I couldn't find any broken behaviour with this change.

Test Plan:
1. Open kcm_baloofile. Check if the exclude folders section fills all available space.
2. Resize the window to make it larger. Check that the exclude folders section resizes to match the window.
3. Open the KCM standalone to and try to resize it smaller than the default size to check if the sizehint is set properly.

Reviewers: #baloo, #vdg, ngraham

Subscribers: GB_2, abetts, bruns, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D21414

M  +32   -17   kcms/baloo/configwidget.ui
M  +4    -2    kcms/baloo/folderselectionwidget.cpp