Bug 407699 - Text format for "add tag" and "remove tag" is inconsistent
Summary: Text format for "add tag" and "remove tag" is inconsistent
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Albums-IconView (show other bugs)
Version: 6.2.0
Platform: Appimage Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-05-18 19:16 UTC by Jens
Modified: 2019-05-19 09:09 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 6.2.0


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jens 2019-05-18 19:16:55 UTC
SUMMARY

This should be easy to resolve.
"Assign tag" context menu has entries like "Name (Root / Parent)", while
"Remove tag" context menu has entries like "Root / Parent / Name".

The formats should be identical, everything else is needlessly confusing. 
I would prefer "Root / Parent / Name" for both.
Comment 1 Maik Qualmann 2019-05-18 21:05:00 UTC
No, if the "Assign tag" context menu begins with "Root / Parent / Name", that is completely confusing, because everything entry starts with the same text. The "Remove tag" context menu is a shortened view of the included tags.

Maik
Comment 2 Jens 2019-05-18 21:08:22 UTC
Nevertheless, Assign Tag and Remove Tag should use the same format, whichever this is. Users adding tags will search for the same format under "Remove tag" to remove the tag.

IMHO, of course.
Comment 3 Maik Qualmann 2019-05-19 09:07:23 UTC
Assign Tag and Remove Tag behave differently depending on the tags set. Remove Tags no longer displays paths if many sub tags present, but activates now sub menus. I cleaned up Assign Tags and removed the root tag because it looks unnecessarily long in the German translation. The tag name first is more concise than the tag path.

Maik
Comment 4 Maik Qualmann 2019-05-19 09:09:24 UTC
Git commit 6eab47955df0dc80889285778ce06da1bad794a4 by Maik Qualmann.
Committed on 19/05/2019 at 09:07.
Pushed by mqualmann into branch 'master'.

remove root tag in "Assign Tags" menu
FIXED-IN: 6.2.0

M  +7    -1    core/libs/tags/widgets/tagspopupmenu.cpp

https://invent.kde.org/kde/digikam/commit/6eab47955df0dc80889285778ce06da1bad794a4