Bug 407677 - Plugin settings not properly passed to Lame converter
Summary: Plugin settings not properly passed to Lame converter
Status: REPORTED
Alias: None
Product: k3b
Classification: Applications
Component: Plugins (show other bugs)
Version: 17.12.3
Platform: Ubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: k3b developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-05-18 08:31 UTC by Arne
Modified: 2019-05-18 20:01 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Lame plugin settings dialog (78.78 KB, image/png)
2019-05-18 08:43 UTC, Arne
Details
Lame plugin settings dialog (Manual Settings) (83.44 KB, image/png)
2019-05-18 08:44 UTC, Arne
Details
Lame plugin settings dialog (Quality settings) (78.21 KB, image/png)
2019-05-18 08:45 UTC, Arne
Details
Lame command line settings in ripping dialog. In the second profile I added the vbr options manually. (72.47 KB, image/png)
2019-05-18 08:47 UTC, Arne
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Arne 2019-05-18 08:31:32 UTC
SUMMARY

When trying to RIP an audio CD with lame and varible bitrate, the output fives always have a bitrate of 128 kbps, no matter how I configured the plug-in settings.

STEPS TO REPRODUCE
1. Open K3b Settings and go to Plugins tab.
2. Select Lame MP3 Converter and open it's configuration dialog (the button to do so has no label by the way)
3. Change the Quality settings to Variable Bitrate (no upper or lower limits, no average) with Joint Stereo.
4.  Not sure if it make a difference but I also set the quality to 9 (highest) in the advanced tab (which is by the way also strange, as the LAME manual says that 0 is highest and 9 is fastest)
5.  Press OK and close the K3b settings.
6.  Enter an audio CD and go to More Actions -> Rip Audio CD
7.  Select start ripping and select "mp3 (Lame)" as a filetype
8.  One more observation on the site: When clicking the "..." button next to the filetype drop-down and editing the Lame settings I get a similar dialog to edit the lame command line, as I was used to with when still working with Ubuntu 16.04. The command is by default set to 
    ```
    lame -r --bitwidth 16 --little-endian -s 44.1 -h --tt %t --ta %a --tl %m --ty %y --tc %c --tn %n - %f
    ```
    and does not change when I update the Lame settings in the plugins settings. It also does not make any difference when I add `-v` here manually.
9.  Start Ripping

The name of the buttons might differ a little, since I am using the German locale and the actual English labels might differ from my translation.

OBSERVED RESULT

Checking the generated output file:
```
file Audioslave\ -\ Out\ of\ Exile\ -\ 01\ -\ Your\ Time\ Has\ Come.mp3 
Audioslave - Out of Exile - 01 - Your Time Has Come.mp3: Audio file with ID3 version 2.3.0, contains:MPEG ADTS, layer III, v1, 128 kbps, 44.1 kHz, JntStereo
```
shows that it always has a bitrate of 128 kbps.

EXPECTED RESULT

A *.mp3 file with a variable bitrate :-)

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Ubuntu 18.04 bionic (x86-64) with Cinnamon 3.6.7
KDE Plasma Version: not installed (bionic offers kde-plasma-desktop 5:100ubuntu2 though)
KDE Frameworks Version: kde-runtime package is installed in version 4:17.08.3-0ubuntu1
Qt Version: 5.9.5

ADDITIONAL INFORMATION
The problems have been observed on Ubuntu 18.08 LTS with K3b 17.12.3 and LAME 64bits version 3.100.
Comment 1 Arne 2019-05-18 08:43:37 UTC
Created attachment 120153 [details]
Lame plugin settings dialog
Comment 2 Arne 2019-05-18 08:44:58 UTC
Created attachment 120154 [details]
Lame plugin settings dialog (Manual Settings)
Comment 3 Arne 2019-05-18 08:45:57 UTC
Created attachment 120155 [details]
Lame plugin settings dialog (Quality settings)
Comment 4 Arne 2019-05-18 08:47:56 UTC
Created attachment 120156 [details]
Lame command line settings in ripping dialog. In the second profile I added the vbr options manually.
Comment 5 Arne 2019-05-18 10:57:27 UTC
One more remark: I just noticed that checking the bitrate with `file <FILENAME>.mp3` also prints 128 kbps if the file is correctly compressed with a variable bitrate. Checking the file properties with Amarok show the correct values (128 kbps on all files of the album when ripped with K3b; between 260 and 280 kbps when ripped using Asunder).
Comment 6 Patrick Silva 2019-05-18 20:01:35 UTC
duplcate of bug 217745 ?