Bug 407623 - Build with trunk LLVM/Clang is broken
Summary: Build with trunk LLVM/Clang is broken
Status: RESOLVED FIXED
Alias: None
Product: clazy
Classification: Developer tools
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Sergio Martins
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-05-16 22:10 UTC by Eugene Zelenko
Modified: 2019-05-22 14:43 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Eugene Zelenko 2019-05-16 22:10:15 UTC 
src/FixItExporter.cpp:141:46: error: no member named 'Fix' in 'clang::tooling::Diagnostic'
            auto &Replacements = ToolingDiag.Fix[replacement.getFilePath()];
                                 ~~~~~~~~~~~ ^
Comment 1 Sergio Martins 2019-05-17 07:01:23 UTC 
Do you have a patch or suggestion ? :)
Comment 2 Eugene Zelenko 2019-05-17 22:01:09 UTC 
Fix is very trivial:

- auto &Replacements = ToolingDiag.Fix[replacement.getFilePath()];
+ auto &Replacements = ToolingDiag.Message.Fix[replacement.getFilePath()];
Comment 3 Sergio Martins 2019-05-19 12:42:21 UTC 
You don't get a linker error with that patch ?
Comment 4 Sergio Martins 2019-05-19 12:44:37 UTC 
Git commit 3e684e046eefff815d62eebd85d087a25944c22f by Sergio Martins.
Committed on 19/05/2019 at 12:43.
Pushed by smartins into branch 'master'.

Fix build with llvm trunk

M  +3    -2    src/FixItExporter.cpp
M  +10   -0    src/SourceCompatibilityHelpers.h

https://commits.kde.org/clazy/3e684e046eefff815d62eebd85d087a25944c22f
Comment 5 Eugene Zelenko 2019-05-19 13:23:49 UTC 
Linker error is independent for API changes.
Comment 6 Sergio Martins 2019-05-22 14:43:30 UTC 
Linker error was my fault, nevermind.