Bug 407563 - [brush preset docker(top bar)] Wrong aspect ratio + a column disapear.
Summary: [brush preset docker(top bar)] Wrong aspect ratio + a column disapear.
Status: RESOLVED WAITINGFORINFO
Alias: None
Product: krita
Classification: Applications
Component: Usability (show other bugs)
Version: 4.2.0-alpha
Platform: Appimage Linux
: NOR normal
Target Milestone: ---
Assignee: vanyossi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-05-15 15:26 UTC by David REVOY
Modified: 2019-05-18 07:18 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
^ screenshot of the bug with annotations in red (94.79 KB, image/jpeg)
2019-05-15 15:26 UTC, David REVOY
Details
A gif screenshot animation of the bug (994.97 KB, image/gif)
2019-05-16 20:31 UTC, David REVOY
Details

Note You need to log in before you can comment on or make changes to this bug.
Description David REVOY 2019-05-15 15:26:17 UTC
Created attachment 120083 [details]
^ screenshot of the bug with annotations in red

Hi,
When using small icons in the brush preset docker (top bar/drop down), the thumbnails change to a rectangular aspect ratio. Also, the last column of presets on the right disapears outside of the frame.

To reproduce:
=============
1. Open a new Krita document
2. Click on the brush presets selector in the top toolbar.
3. In the preferences of the docker (on top-right, next to the "Tags" button) change the size for a smaller one.

Result:
=======
- Wrong aspect ratio of the thumbnails.
- A column of preset almost disappear on rigth.
Comment 1 vanyossi 2019-05-16 19:57:41 UTC
I can't reproduce this bug

Tested with Appimage and compiled sources

Krita

 Version: 4.2.0-alpha (git 75bba48)
 Languages: en_US
 Hidpi: true

Qt

  Version (compiled): 5.12.2
  Version (loaded): 5.12.2

OS Information

  Build ABI: x86_64-little_endian-lp64
  Build CPU: x86_64
  CPU: x86_64
  Kernel Type: darwin
  Kernel Version: 18.5.0
  Pretty Productname: macOS Mojave (10.14)
  Product Type: osx
  Product Version: 10.14


AND ================

Krita

 Version: 4.2.0-beta
 Languages: en_US
 Hidpi: false

Qt

  Version (compiled): 5.12.2
  Version (loaded): 5.12.2

OS Information

  Build ABI: x86_64-little_endian-lp64
  Build CPU: x86_64
  CPU: x86_64
  Kernel Type: linux
  Kernel Version: 4.15.0-47-generic
  Pretty Productname: Ubuntu 18.04.2 LTS
  Product Type: ubuntu
  Product Version: 18.04



Can you proivide more info on the system and krita version used?
Comment 2 David REVOY 2019-05-16 20:12:25 UTC
Hey Vanyossi,
Weird, I can't now reproduce it on git~master, but I still can on a appimage from 2 days ago krita-4.2.0-alpha-ca5aeb7-x86_64.appimage (with the list 'all', and sliding the slider to change size of icons). I'll download the nightly appimage to see if I can reproduce it or if it.
(Note: I'm on Kubuntu 18.04LTS.)
Comment 3 David REVOY 2019-05-16 20:31:27 UTC
Created attachment 120120 [details]
A gif screenshot animation of the bug

So, I confirm I can reproduce that on the latest appimage from https://binary-factory.kde.org/job/Krita_Nightly_Appimage_Build/ , item #485: https://binary-factory.kde.org/job/Krita_Nightly_Appimage_Build/lastSuccessfulBuild/artifact/krita-4.2.0-beta-fb226d0-x86_64.appimage 

I also confirm I can't reproduce it on git~master (weird, because git master is on fb226d0 on my build)

Also; I suspect it needs a long list of preset.
Comment 4 Bug Janitor Service 2019-05-17 04:33:15 UTC
Thanks for your comment!

Automatically switching the status of this bug to REPORTED so that the KDE team
knows that the bug is ready to get confirmed.

In the future you may also do this yourself when providing needed information.
Comment 5 vanyossi 2019-05-17 06:13:22 UTC
"Also; I suspect it needs a long list of preset."

I think this could be it. the window calculates sweet spot between columns and rows, but if presets are to numerous it creates wrongly another column as height is limiting.

Confirming
Comment 6 David REVOY 2019-05-17 08:53:00 UTC
Thank you Vanyossi,
Also, I think it is a bug with Qt.
On compiled sources my system has 5.9.5 and I can't reproduce.
I know the appimage embed a newer Qt, and as I can reproduce in it, it might be playing in the issue.
Comment 7 vanyossi 2019-05-18 05:51:07 UTC
Hi, I installed everybundle in the resources page and I couldn't reproduce on master nor beta builds. but I could be missing a corner case.

I do strongly suspect now this is a bug in Qt as Preset chooser is only a facade to QTableView, and the only thing krita does is set the column using an internal method of Qt.

However I did send a patch to ensure we never loose the aspect ratio, but since that only happened when presets where presented in one column, i doubt this will make a difference on the faulty setup.

I will set this as RESOLVED WAITINGFORINFO, an we can reopen if this still persists.
Comment 8 David REVOY 2019-05-18 07:18:20 UTC
Thank you for your patience and investigation on this bug. I'll download future appimage and test them for that. I'll keep you informed in the next week.