Bug 407558 - Falkon thinks every string containing a dot is a URL
Summary: Falkon thinks every string containing a dot is a URL
Status: REPORTED
Alias: None
Product: Falkon
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: David Rosca
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-05-15 13:14 UTC by Jan Przybylak
Modified: 2019-06-04 14:55 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Przybylak 2019-05-15 13:14:55 UTC
SUMMARY
Falkon thinks every string containing a dot is a URL. Therefore, in the combined search/addres bar, a string with a dot will not be send to a search engine, it tries to open the page instead (which of course doesn't exist in this case)

STEPS TO REPRODUCE
1. Enter something.something into the search/address bar
2. Press enter

OBSERVED RESULT
Falkon will try to load a page that does not exist.

EXPECTED RESULT
Falkon recognises that the letters after the dot are not a valid TLD and therefore treats the string like a regular search query.

PROPOSED SOLUTION
Don't treat every string containing a dot like a URL. Check if the URL is valid, for example by comparing it to a list of valid TLDs. If it is not valid, treat it like a search query.
Also automatically treat every string beginning with `https://` as a URL.