Bug 407504 - After changing the display resolution while a notification is showing does not change the position of the notification
Summary: After changing the display resolution while a notification is showing does no...
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Notifications (show other bugs)
Version: master
Platform: Other Linux
: NOR normal
Target Milestone: 1.0
Assignee: Kai Uwe Broulik
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-05-13 17:12 UTC by Alex Nemeth
Modified: 2019-05-24 13:47 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.16.0


Attachments
video of it (2.06 MB, video/webm)
2019-05-13 17:12 UTC, Alex Nemeth
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Nemeth 2019-05-13 17:12:02 UTC
Created attachment 120047 [details]
video of it

SUMMARY
While I change the screen resolution while a notification is on the screen, the notification stays in the initial position and does not move to the designated corner.

STEPS TO REPRODUCE
1. Make a notification pop-up
2. Change the screen resolution

OBSERVED RESULT
Notification window stays in a fixed position.

EXPECTED RESULT
It should move to the corner.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: KDE Neon dev unstable latest (as of 2019.May.13)
(available in About System)
KDE Plasma Version: 5.15.80
KDE Frameworks Version: 5.58.0
Qt Version: 5.12.0

ADDITIONAL INFORMATION
See the attached video for more info.
Comment 1 Kai Uwe Broulik 2019-05-23 08:58:09 UTC
Can you try again with a newer version? I cannot reproduce here. Maybe [1] fixed that by having it re-evaluate the binding also on screen geometry change or something.

[1] https://cgit.kde.org/plasma-workspace.git/commit/?h=Plasma/5.16&id=1e175254dd8c7c5230fd5f41d2c4de55cb6d50d1
Comment 2 Alex Nemeth 2019-05-23 21:45:02 UTC
I can confirm that this bug no longer happens with the latest build
Comment 3 Kai Uwe Broulik 2019-05-24 12:48:14 UTC
Git commit f76c949dc9623974eb55759776795dfab2e741e7 by Kai Uwe Broulik.
Committed on 24/05/2019 at 12:45.
Pushed by broulik into branch 'Plasma/5.16'.

[Notifications] Avoid stale screenRect

AppletInterface does not emit change signals for screen properties, only ContainmentInterface does it.
Since a fix will only be in a future Frameworks version 5.16 won't depend on, mitigate the effect by not caching the property.
The property was only a lazy Connections replacement anyway.
Also, compress screen change updates to avoid flickery animation of the popup as you resize the panel.
Related: bug 399257

Differential Revision: https://phabricator.kde.org/D21365

M  +22   -9    applets/notifications/package/contents/ui/global/Globals.qml

https://commits.kde.org/plasma-workspace/f76c949dc9623974eb55759776795dfab2e741e7