Bug 407468 - Metadata Edit window is too small
Summary: Metadata Edit window is too small
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Plugin-Generic-MetadataEdit (show other bugs)
Version: 6.1.0
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-05-12 17:59 UTC by Patrick Silva
Modified: 2022-12-25 15:20 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 8.0.0
Sentry Crash Report:


Attachments
screenshot (126.86 KB, image/png)
2019-05-12 17:59 UTC, Patrick Silva
Details
screenshot (146.11 KB, image/png)
2022-11-02 11:51 UTC, Patrick Silva
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2019-05-12 17:59:14 UTC
Created attachment 120019 [details]
screenshot

SUMMARY
When I open the settings window for the first time, it looks like what we can see in the attached screenshot.

STEPS TO REPRODUCE
1. open showfoto
2. open its settings window
3. 

EXPECTED RESULT
default size of settings window is better adjusted

SOFTWARE/OS VERSIONS
Operating System: Arch Linux 
KDE Plasma Version: 5.15.5
KDE Frameworks Version: 5.57.0
Qt Version: 5.13.0 beta3
Comment 1 Maik Qualmann 2019-05-12 18:06:22 UTC

*** This bug has been marked as a duplicate of bug 404761 ***
Comment 2 Maik Qualmann 2019-05-12 18:19:55 UTC
Note: digiKam-6.1.0 has a settings window of 800x600. Their small size comes from a previously created configuration file of an older digiKam version.

Maik
Comment 3 caulier.gilles 2022-08-05 17:19:50 UTC
Reassigned to Metadata Edit as this problem is reproducible in this plugin
Comment 4 caulier.gilles 2022-08-06 12:37:17 UTC
Git commit 2b395dca2709570124cebf992fa6ae8cb8338c9a by Gilles Caulier.
Committed on 06/08/2022 at 12:36.
Pushed by cgilles into branch 'master'.

MetadataEdit plugin: make dialog fully resizable
FIXED-IN: 8.0.0

M  +1    -1    NEWS
M  +1    -0    core/dplugins/generic/metadata/metadataedit/CMakeLists.txt
C  +13   -35   core/dplugins/generic/metadata/metadataedit/dialog/metadataeditpage.cpp [from: core/dplugins/generic/metadata/metadataedit/exif/exiflens.h - 060% similarity]
C  +10   -27   core/dplugins/generic/metadata/metadataedit/dialog/metadataeditpage.h [from: core/dplugins/generic/metadata/metadataedit/exif/exiflens.h - 063% similarity]
M  +9    -6    core/dplugins/generic/metadata/metadataedit/exif/exifadjust.cpp
M  +2    -1    core/dplugins/generic/metadata/metadataedit/exif/exifadjust.h
M  +9    -6    core/dplugins/generic/metadata/metadataedit/exif/exifcaption.cpp
M  +2    -1    core/dplugins/generic/metadata/metadataedit/exif/exifcaption.h
M  +9    -6    core/dplugins/generic/metadata/metadataedit/exif/exifdatetime.cpp
M  +2    -1    core/dplugins/generic/metadata/metadataedit/exif/exifdatetime.h
M  +10   -6    core/dplugins/generic/metadata/metadataedit/exif/exifdevice.cpp
M  +2    -1    core/dplugins/generic/metadata/metadataedit/exif/exifdevice.h
M  +12   -6    core/dplugins/generic/metadata/metadataedit/exif/exifeditwidget.cpp
M  +9    -6    core/dplugins/generic/metadata/metadataedit/exif/exiflens.cpp
M  +2    -1    core/dplugins/generic/metadata/metadataedit/exif/exiflens.h
M  +9    -6    core/dplugins/generic/metadata/metadataedit/exif/exiflight.cpp
M  +2    -1    core/dplugins/generic/metadata/metadataedit/exif/exiflight.h
M  +9    -6    core/dplugins/generic/metadata/metadataedit/iptc/iptccategories.cpp
M  +2    -1    core/dplugins/generic/metadata/metadataedit/iptc/iptccategories.h
M  +9    -6    core/dplugins/generic/metadata/metadataedit/iptc/iptccontent.cpp
M  +2    -1    core/dplugins/generic/metadata/metadataedit/iptc/iptccontent.h
M  +9    -6    core/dplugins/generic/metadata/metadataedit/iptc/iptccredits.cpp
M  +2    -1    core/dplugins/generic/metadata/metadataedit/iptc/iptccredits.h
M  +9    -9    core/dplugins/generic/metadata/metadataedit/iptc/iptceditwidget.cpp
M  +9    -6    core/dplugins/generic/metadata/metadataedit/iptc/iptcenvelope.cpp
M  +2    -1    core/dplugins/generic/metadata/metadataedit/iptc/iptcenvelope.h
M  +9    -6    core/dplugins/generic/metadata/metadataedit/iptc/iptckeywords.cpp
M  +2    -1    core/dplugins/generic/metadata/metadataedit/iptc/iptckeywords.h
M  +9    -6    core/dplugins/generic/metadata/metadataedit/iptc/iptcorigin.cpp
M  +2    -1    core/dplugins/generic/metadata/metadataedit/iptc/iptcorigin.h
M  +9    -6    core/dplugins/generic/metadata/metadataedit/iptc/iptcproperties.cpp
M  +2    -1    core/dplugins/generic/metadata/metadataedit/iptc/iptcproperties.h
M  +9    -6    core/dplugins/generic/metadata/metadataedit/iptc/iptcstatus.cpp
M  +2    -1    core/dplugins/generic/metadata/metadataedit/iptc/iptcstatus.h
M  +3    -0    core/dplugins/generic/metadata/metadataedit/metadataeditplugin.cpp
M  +9    -6    core/dplugins/generic/metadata/metadataedit/xmp/xmpcategories.cpp
M  +2    -1    core/dplugins/generic/metadata/metadataedit/xmp/xmpcategories.h
M  +6    -6    core/dplugins/generic/metadata/metadataedit/xmp/xmpcontent.cpp
M  +2    -1    core/dplugins/generic/metadata/metadataedit/xmp/xmpcontent.h
M  +9    -8    core/dplugins/generic/metadata/metadataedit/xmp/xmpcredits.cpp
M  +2    -1    core/dplugins/generic/metadata/metadataedit/xmp/xmpcredits.h
M  +8    -8    core/dplugins/generic/metadata/metadataedit/xmp/xmpeditwidget.cpp
M  +9    -6    core/dplugins/generic/metadata/metadataedit/xmp/xmpkeywords.cpp
M  +2    -1    core/dplugins/generic/metadata/metadataedit/xmp/xmpkeywords.h
M  +9    -6    core/dplugins/generic/metadata/metadataedit/xmp/xmporigin.cpp
M  +2    -1    core/dplugins/generic/metadata/metadataedit/xmp/xmporigin.h
M  +9    -6    core/dplugins/generic/metadata/metadataedit/xmp/xmpproperties.cpp
M  +2    -1    core/dplugins/generic/metadata/metadataedit/xmp/xmpproperties.h
M  +9    -6    core/dplugins/generic/metadata/metadataedit/xmp/xmpstatus.cpp
M  +2    -1    core/dplugins/generic/metadata/metadataedit/xmp/xmpstatus.h
M  +15   -9    core/libs/widgets/metadata/utils/subjectwidget.cpp
M  +2    -2    core/libs/widgets/metadata/utils/subjectwidget.h
M  +1    -1    core/utilities/setup/setupdatabase.cpp

https://invent.kde.org/graphics/digikam/commit/2b395dca2709570124cebf992fa6ae8cb8338c9a
Comment 5 Patrick Silva 2022-11-02 11:43:20 UTC
This bug is still reproducible with showfoto master on neon unstable.
Comment 6 caulier.gilles 2022-11-02 11:44:42 UTC
Please take a screenshot of the dysfunction. It's perhaps a translations problem with long strings.

Here in English, i cannot reproduce...

Gilles Caulier
Comment 7 Patrick Silva 2022-11-02 11:51:01 UTC
Created attachment 153397 [details]
screenshot

My system language is english.
Comment 8 caulier.gilles 2022-11-02 11:52:46 UTC
Resize the dialog, close the dialog, re-open the dialog : It must remember the size.

Gilles Caulier
Comment 9 Patrick Silva 2022-11-02 11:56:11 UTC
Right. But the dialog should not be so small by default.
Comment 10 Maik Qualmann 2022-11-02 18:02:15 UTC
What your screenshot shows cannot be the configure dialog of an empty config file. A look at the source code reveals that the minimum size is 800x600 if no size is saved. Of course you can push it together to this size and the next time you start it, this small size will also be displayed. But that is intentional and we will not change it. A new user gets a configuration dialog with 800x600, which is not very big depending on the desktop resolution.

Maik
Comment 11 caulier.gilles 2022-11-02 21:11:20 UTC
Git commit bdabe8a029c31c41ccaa8a5412806c5ec2c80c89 by Gilles Caulier.
Committed on 02/11/2022 at 21:06.
Pushed by cgilles into branch 'master'.

At least, we can call adjustSize() to make dialog size not too small at first run.

M  +1    -0    core/dplugins/generic/metadata/metadataedit/dialog/metadataeditdialog.cpp

https://invent.kde.org/graphics/digikam/commit/bdabe8a029c31c41ccaa8a5412806c5ec2c80c89
Comment 12 Maik Qualmann 2022-11-02 21:29:22 UTC
Git commit ef8ace6925ca55223d167f841144ff721238d356 by Maik Qualmann.
Committed on 02/11/2022 at 21:28.
Pushed by mqualmann into branch 'master'.

optimize first dialog size for larger screen resolutions

M  +7    -2    core/libs/dplugins/widgets/dplugindialog.cpp
M  +28   -4    core/utilities/setup/setup.cpp

https://invent.kde.org/graphics/digikam/commit/ef8ace6925ca55223d167f841144ff721238d356
Comment 13 Patrick Silva 2022-12-04 10:40:05 UTC
(In reply to Maik Qualmann from comment #10)
> What your screenshot shows cannot be the configure dialog of an empty config
> file. A look at the source code reveals that the minimum size is 800x600 if
> no size is saved. 

Where is the config file located? I have created a new user account on neon unstable and the bug is reproducible on it.
Comment 14 Maik Qualmann 2022-12-04 11:05:23 UTC
This only works with a new config. To test it you need to remove the entire section of the tool/dialog in question in the config file.
Just enlarge the window, it will be saved. Note that a small window that has already been saved will also be restored in this way, we do not override the user's wish.
The behavior will change again with new versions anyway. The KF5 developers added the monitor connector string as a parameter. It turns out that this leads to even more problems. If you're interested, I'll dig out the bug reports.

Maik
Comment 15 Maik Qualmann 2022-12-04 11:09:03 UTC
Also note that this report was closed for digiKam-8.0.0, I assume you are still using a digiKam-7.x.x version.

Maik
Comment 16 Patrick Silva 2022-12-04 11:16:07 UTC
neon unstable runs git versions, including digiKam 8.0.0-git.
Comment 17 Maik Qualmann 2022-12-04 11:54:44 UTC
I see now that your screenshots are about Showfoto. I can only reproduce it using the Showfoto setup dialog - will fix...

If it's because of the application window itself, this is the KXmlGui. Here we have to wait until the KF5 team has fixed the matter.

Maik
Comment 18 Maik Qualmann 2022-12-04 12:16:02 UTC
Git commit 189888948208b3c627fe690ebbc53847d2d5b7d2 by Maik Qualmann.
Committed on 04/12/2022 at 12:14.
Pushed by mqualmann into branch 'master'.

fix initial window size from Showfoto setup dialog

M  +29   -3    core/showfoto/setup/showfotosetup.cpp

https://invent.kde.org/graphics/digikam/commit/189888948208b3c627fe690ebbc53847d2d5b7d2
Comment 19 Maik Qualmann 2022-12-25 15:20:20 UTC
Git commit 413dbe28f7431d7b26059685a352d76c3aab01d2 by Maik Qualmann.
Committed on 25/12/2022 at 15:12.
Pushed by mqualmann into branch 'master'.

fix default dialog size if config is broken
Related: bug 374783
FIXED-IN: 8.0.0

M  +1    -1    NEWS
M  +4    -29   core/libs/dplugins/widgets/dplugindialog.cpp
M  +11   -0    core/libs/widgets/mainview/dxmlguiwindow.cpp
M  +1    -0    core/libs/widgets/mainview/dxmlguiwindow.h
M  +4    -0    core/libs/widgets/mainview/dxmlguiwindow_p.h
M  +4    -29   core/showfoto/setup/showfotosetup.cpp
M  +4    -29   core/utilities/setup/setup.cpp

https://invent.kde.org/graphics/digikam/commit/413dbe28f7431d7b26059685a352d76c3aab01d2