Bug 407462 - do not show notification before the user to click "Save" button of the save dialog
Summary: do not show notification before the user to click "Save" button of the save d...
Status: RESOLVED INTENTIONAL
Alias: None
Product: plasma-browser-integration
Classification: Plasma
Component: Opera (show other bugs)
Version: unspecified
Platform: Neon Linux
: NOR minor
Target Milestone: ---
Assignee: Kai Uwe Broulik
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-05-12 14:29 UTC by Patrick Silva
Modified: 2021-04-16 11:33 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
screenshot (144.29 KB, image/jpeg)
2019-05-12 14:29 UTC, Patrick Silva
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2019-05-12 14:29:26 UTC
Created attachment 120011 [details]
screenshot

SUMMARY
When you use Opera and Chromium browsers, Plasma shows a notification immediately when the dialog to save a download shows up. Such behavior does not occur when I use Firefox.
As we can see in attached screenshot, the notification may cover the "Save" button of the save dialog.

STEPS TO REPRODUCE
1. enable "Ask where to save each file before downloading"
option in Opera/chromium settings
2. download any file
3. 

OBSERVED RESULT
already described above

EXPECTED RESULT
the same behavior that occurs when you use firefox:
plasma only shows the download notification after you click the "Save" button of the save dialog.

Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.15.80
KDE Frameworks Version: 5.58.0
Qt Version: 5.12.0
Comment 1 Kai Uwe Broulik 2019-05-13 08:22:38 UTC
There's no real way for us to tell. We get an in_progress download. We could perhaps check whether we have a filename but that requires some refactoring since the our KJob itself tracks the job which is created as soon as we get a download from the browser.
Comment 2 Bug Janitor Service 2021-04-09 18:59:37 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-browser-integration/-/merge_requests/42
Comment 3 Kai Uwe Broulik 2021-04-15 15:04:00 UTC
We have decided that this is useful/intentional because the browser still starts the download, causing network activity, before a filename is chosen. See also discussion on the linked MR, sorry.
Comment 4 Patrick Silva 2021-04-16 11:33:50 UTC
Humm, in this case the behavior should be consistent at least.
When I download something with Firefox, notification only appears after click
on "Save" button of save dialog despite Firefox also causes network activity
immediately after click on download link.