Bug 407460 - new notifications: "Open" and hamburger buttons should have the same height
Summary: new notifications: "Open" and hamburger buttons should have the same height
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Notifications (show other bugs)
Version: master
Platform: Neon Linux
: NOR normal
Target Milestone: 1.0
Assignee: Kai Uwe Broulik
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-05-12 14:04 UTC by Patrick Silva
Modified: 2019-05-24 14:27 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.16.0


Attachments
screenshot (9.14 KB, image/jpeg)
2019-05-12 14:05 UTC, Patrick Silva
Details
Smaller icon only button (4.74 KB, image/png)
2019-05-13 09:54 UTC, Kai Uwe Broulik
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2019-05-12 14:04:29 UTC
SUMMARY
As we can see in the attached screenshot, currently the "Open" button has greater height.

STEPS TO REPRODUCE
1. copy/move a big file using Dolphin
2. wait the file operation to be completed
3. 

Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.15.80
KDE Frameworks Version: 5.58.0
Qt Version: 5.12.0
Comment 1 Patrick Silva 2019-05-12 14:05:01 UTC
Created attachment 120010 [details]
screenshot
Comment 2 Nate Graham 2019-05-13 04:15:26 UTC
Probably an issue with PlasmaComponents but maybe we can do a local workaround like we did for the login and lock screens: https://cgit.kde.org/plasma-workspace.git/tree/lookandfeel/contents/lockscreen/MainBlock.qml#n97
Comment 3 Kai Uwe Broulik 2019-05-13 07:16:36 UTC
I would prefer this to be fixed in PlasmaComponents. Especially since that workaround subtracts half of units.smallSpacing which is quite a magic number.
Comment 4 Kai Uwe Broulik 2019-05-13 07:20:31 UTC
https://phabricator.kde.org/D21181
Comment 5 David Edmundson 2019-05-13 08:59:49 UTC
I just updated 

plasma-framework: tests/components/button.qml


I get buttons being the same height. There's something else going on in this patch that I don't understand.
Comment 6 Kai Uwe Broulik 2019-05-13 09:08:18 UTC
Try with a button that has just an icon but no text
Comment 7 David Edmundson 2019-05-13 09:12:23 UTC
I did, it looks fine.
Comment 8 Kai Uwe Broulik 2019-05-13 09:54:15 UTC
Created attachment 120035 [details]
Smaller icon only button

Look how that button with just an icon is slightly smaller
Comment 9 Nate Graham 2019-05-13 13:58:42 UTC
I see the same height discrepancy, BTW.
Comment 10 David Edmundson 2019-05-15 18:15:29 UTC
So the code is:

max(fontSize * 1.6,   textSize + marginTop + marginBottom)

fontSize will apply for icon only, but textSize will be 0

In theory fontSize and textSize should be the same. Clearly you guys have margins that are bigger than your font * 0.6

It seems this doesn't exist with PC3, so maybe it's not worth fixing the root issue.
Comment 11 Kai Uwe Broulik 2019-05-24 13:48:03 UTC
Git commit 19e8b39b5b46d3d09818493c916df533ce879459 by Kai Uwe Broulik.
Committed on 24/05/2019 at 13:47.
Pushed by broulik into branch 'Plasma/5.16'.

[Notifications] Ensure "Open" and "More Options" button have the same height

Differential Revision: https://phabricator.kde.org/D21181

M  +3    -0    applets/notifications/package/contents/ui/JobItem.qml

https://commits.kde.org/plasma-workspace/19e8b39b5b46d3d09818493c916df533ce879459