Bug 407427 - Static word wrapper not rendered anymore
Summary: Static word wrapper not rendered anymore
Status: RESOLVED FIXED
Alias: None
Product: kate
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Debian unstable Linux
: NOR normal
Target Milestone: ---
Assignee: KWrite Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-05-11 13:22 UTC by nfxjfg
Modified: 2019-07-16 15:32 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description nfxjfg 2019-05-11 13:22:34 UTC
SUMMARY

The line that is rendered when "Show static word wrap marker is checked is not rendered anymore. Instead of the line, nothing is rendered. The line is normally a gray thin line at 80 columns (can be configured)

STEPS TO REPRODUCE
1. enable that settings option
2. open a file

OBSERVED RESULT

Don't see a vertical word wrap marker line.

EXPECTED RESULT

Should see a vertical word wrap marker line.

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: yes/no
(available in About System)
KDE Plasma Version: uh I don't run KDE, so no clue
KDE Frameworks Version: 5.54.0
Qt Version: 5.11.3

ADDITIONAL INFORMATION

Happens in kate 18.03.70 (what I'm using mainly), 18.08.0 (current Debian unstable version), and 18.12.3 (current Ubuntu version).

It did not happen in 18.03.70 a few weeks or months ago. I did not rebuild kate or any of the other components that are built when using the build instructions on your website. This hints that a change to any of the dependencies might have caused this. I still have a few running kate instances that render the indicator correctly, but their about dialogs show the same Qt and KDE frameworks versions.
Comment 1 Lothar 2019-05-12 20:32:15 UTC
Perhaps not a fixed font in use?
Comment 2 nfxjfg 2019-05-13 15:53:13 UTC
It's a fixed width font. Liberation Mono, Regular, 10.0 points. Hidpi with QT_SCALE_FACTOR=2.
Comment 3 nfxjfg 2019-05-17 15:36:07 UTC
I went and commented the "QFontInfo(config()->font()).fixedPitch()" check in katerenderer.cpp. This makes the marker appear again.

The font I'm using is most definitely fixed width, though. Some kind of font handling regression in some other library? Checking fc-cat and looking for "Liberation Mono", all related entries end with "variable=false".

Anything else I could check?
Comment 4 Ahmad Samir 2019-06-22 13:26:21 UTC
I couldn't reproduce this issue, the static word wrap marker is shown here with Liberation Mono at 10pt. Note that I don't have a HiDPI display.
Comment 5 nfxjfg 2019-06-22 16:55:56 UTC
Still happens to me. This is on Debian unstable. The kate version I tested is also from Debian unstable. What I wrote in my previous post probably still holds true. It must be a change in some of the dependencies. (Qt? fontconfig?)
Comment 6 Christoph Cullmann 2019-07-13 19:02:29 UTC
    show static word wrap marker always if requested
    
    Summary:
    don't check for fixed pitch font, as this seems to be not properly attributed
    to all kind of fonts
    
    see bug 344290
    
    Subscribers: kwrite-devel, kde-frameworks-devel
    
    Tags: #kate, #frameworks
    
    Differential Revision: https://phabricator.kde.org/D21380
Comment 7 nfxjfg 2019-07-16 14:02:22 UTC
Thanks. If anyone knows why this happened or how to analyze it, that would still be interesting.
Comment 8 Ahmad Samir 2019-07-16 15:32:32 UTC
I tested with liberation-fonts 2.00.1, maybe you have a different version?