Bug 407417 - [4.2 alpha] Moving selection is very laggy
Summary: [4.2 alpha] Moving selection is very laggy
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Tools/Selection (show other bugs)
Version: nightly build (please specify the git hash!)
Platform: Microsoft Windows Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: Dmitry Kazakov
URL:
Keywords:
: 411948 (view as bug list)
Depends on:
Blocks:
 
Reported: 2019-05-11 08:55 UTC by acc4commissions
Modified: 2020-06-22 04:23 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
gif recording of the problem (90.97 KB, image/gif)
2019-05-11 08:55 UTC, acc4commissions
Details

Note You need to log in before you can comment on or make changes to this bug.
Description acc4commissions 2019-05-11 08:55:30 UTC
Created attachment 119975 [details]
gif recording of the problem

SUMMARY

git 89de24c

It's been this way since it was first implememted but I thought it was just a performance problem due to its early stage of development. But I saw the introduction video(https://www.youtube.com/watch?v=gWv--Do9L0E) and it seemed very smoother then it was in my PC.

+ And is it also a bug that I have to move the cursor to its border to move the selection? It also seems different in the video.

Maybe I'm missing something. I wouldn't know.

STEPS TO REPRODUCE
1. Make a selection.
2. Try to move it.


SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
Comment 1 vanyossi 2019-05-11 15:05:38 UTC
Are you on windwows? What specs is your PC?

Also, does "Canvas GRaphics Acceleration" is enabled in "Settings > Display"?? If on windows it is best to set to "ANGLE"
Comment 2 acc4commissions 2019-05-11 21:48:11 UTC
(In reply to vanyossi from comment #1)
> Are you on windwows? What specs is your PC?
> 
> Also, does "Canvas GRaphics Acceleration" is enabled in "Settings >
> Display"?? If on windows it is best to set to "ANGLE"

Yes, CGA is on, and it's even slower with ANGLE.

It's actually much faster when the CGA setting is disabled. Kinda weird.
Comment 3 acc4commissions 2019-05-11 21:51:19 UTC
Spec

OS : Windows 7 (x64)
CPU : Intel(R) Core(TM) i7-2600
VGA : Radeon RX 560 Series
RAM : 16G
Tablet : Wacom Intuos Pro
Comment 4 acc4commissions 2019-07-31 16:13:57 UTC
Still reproducible in 4.2.4.
Comment 5 Dmitry Kazakov 2019-08-02 11:55:56 UTC
Hi, acc4commissions!

What image size do you use? Can you give a full screenshot?
Comment 6 acc4commissions 2019-08-02 12:35:07 UTC
I usually use around 3000 x 3000px canvas, and it slightly gets better the smaller the canvas is(the size of selection area doesn't affect on this). But is it supposed to vary as the canvas size changes?;
Comment 7 wolthera 2019-09-21 15:22:52 UTC
*** Bug 411948 has been marked as a duplicate of this bug. ***
Comment 8 acc4commissions 2020-03-02 10:21:10 UTC
Yes, it definitely gets better when the document canvas size is smaller.
Comment 9 acc4commissions 2020-03-02 10:27:19 UTC
(In reply to acc4commissions from comment #8)
> Yes, it definitely gets better when the document canvas size is smaller.

Still, it's laggy even in the smallest canvas that I can test. (around 9px x 9px)
Comment 10 Halla Rempt 2020-05-05 08:13:55 UTC
When comparing between Linux and Windows on two different computers, on Windows 10 moving the selection is visibly slower than on Linux.
Comment 11 Halla Rempt 2020-05-05 08:14:38 UTC
Note that on Windows 7, canvas acceleration may take a really slow path because the display drivers don't support Krita anymore.
Comment 12 Dmitry Kazakov 2020-06-03 12:22:08 UTC
Hi, acc4commissions!

Could you check Krita 4.3 Beta2, is the bug still reproducible?

I had two rounds of optimizations that could fix this bug:

1) Optimize FPS of the move tool (August 2019, dcdef2ea)
2) Optimize Vector Shapes moving (including in the vector selections) (January 2020, 26179006)

The latter fix was not included into any Krita release in 4.2.x branch. It will only appear in 4.3.

Here is the link for the most recent package:
https://binary-factory.kde.org/job/Krita_Stable_Windows_Build/

Please reopen the bug if it is still reproducible in the nightly stable.
Comment 13 acc4commissions 2020-06-03 13:08:51 UTC
(In reply to Dmitry Kazakov from comment #12)
> Hi, acc4commissions!
> 
> Could you check Krita 4.3 Beta2, is the bug still reproducible?
> 
> I had two rounds of optimizations that could fix this bug:
> 
> 1) Optimize FPS of the move tool (August 2019, dcdef2ea)
> 2) Optimize Vector Shapes moving (including in the vector selections)
> (January 2020, 26179006)
> 
> The latter fix was not included into any Krita release in 4.2.x branch. It
> will only appear in 4.3.
> 
> Here is the link for the most recent package:
> https://binary-factory.kde.org/job/Krita_Stable_Windows_Build/
> 
> Please reopen the bug if it is still reproducible in the nightly stable.

Thanks for the patch but no, nothing seem changed on this at least on my system.
Comment 14 Bug Janitor Service 2020-06-04 04:33:16 UTC
Thanks for your comment!

Automatically switching the status of this bug to REPORTED so that the KDE team
knows that the bug is ready to get confirmed.

In the future you may also do this yourself when providing needed information.
Comment 15 Dmitry Kazakov 2020-06-04 11:02:40 UTC
Okya, I can only reproduce the bug on a virtual machine with windows 7 and without any graphics drivers installed, that is, using "Software Renderer".

My test resutls:

1) Win7, VM, no GPU drivers, Software Renderer: SLOW
2) Win10, Normal PC, Angle: OK
2) Win10, Normal PC, openGL: OK
2) Win10, Normal PC, Software Renderer: OK
Comment 16 acc4commissions 2020-06-04 12:47:34 UTC
(In reply to Dmitry Kazakov from comment #15)
> Okya, I can only reproduce the bug on a virtual machine with windows 7 and
> without any graphics drivers installed, that is, using "Software Renderer".
> 
> My test resutls:
> 
> 1) Win7, VM, no GPU drivers, Software Renderer: SLOW
> 2) Win10, Normal PC, Angle: OK
> 2) Win10, Normal PC, openGL: OK
> 2) Win10, Normal PC, Software Renderer: OK

If you need to ignore this for any development purpose because it's Win7 specific, I personally can live with this bug. So as you wish.
Comment 17 Dmitry Kazakov 2020-06-09 08:50:27 UTC
I have unpacked an old computer with Win7 and going to check on that some time later :)
Comment 18 Dmitry Kazakov 2020-06-10 15:28:14 UTC
Well, I cannot reproduce the problem on my Win7 device. Though it has a dicreete GPU card...

acc4commissions, could you please attach your system info on from the affected machine via Help->Show System Information...
Comment 19 acc4commissions 2020-06-10 16:02:24 UTC
(In reply to Dmitry Kazakov from comment #18)
> Well, I cannot reproduce the problem on my Win7 device. Though it has a
> dicreete GPU card...
> 
> acc4commissions, could you please attach your system info on from the
> affected machine via Help->Show System Information...

I just tested git cba3084 and the problem is gone(It's not as smooth as it was in the introduction video, but ok). I haven't been using the feature for a while assuming this was not fixed so I'm not sure what patch fixed this.
Comment 20 acc4commissions 2020-06-10 16:11:27 UTC
(In reply to acc4commissions from comment #19)
> (In reply to Dmitry Kazakov from comment #18)
> > Well, I cannot reproduce the problem on my Win7 device. Though it has a
> > dicreete GPU card...
> > 
> > acc4commissions, could you please attach your system info on from the
> > affected machine via Help->Show System Information...
> 
> I just tested git cba3084 and the problem is gone(It's not as smooth as it
> was in the introduction video, but ok). I haven't been using the feature for
> a while assuming this was not fixed so I'm not sure what patch fixed this.

Seems like it was already gone in git bc1f57d.
Comment 21 Dmitry Kazakov 2020-06-10 20:24:29 UTC
yay! thanks a lot! :)
Comment 22 acc4commissions 2020-06-22 04:23:43 UTC
It got slow again in the latest nightlies. But as I said, I can live with this.