Bug 407337 - Song duration display in the Playlist regressed recently
Summary: Song duration display in the Playlist regressed recently
Status: RESOLVED FIXED
Alias: None
Product: Elisa
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Matthieu Gallien
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-05-08 15:36 UTC by Nate Graham
Modified: 2019-05-14 05:25 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments
All song durations elided (113.14 KB, image/png)
2019-05-08 15:36 UTC, Nate Graham
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2019-05-08 15:36:03 UTC
Created attachment 119915 [details]
All song durations elided

Elisa from git master. See attachment.
Comment 1 Matthieu Gallien 2019-05-08 17:36:36 UTC
I am going to fix all usage of TextMetrics and also add rounding when a font.pointSize is multiplied. Let's see if it's enough.
Comment 2 Matthieu Gallien 2019-05-12 20:09:10 UTC
I am working on this.
Comment 3 Matthieu Gallien 2019-05-13 20:10:15 UTC
Patch to try to fix that issue: https://phabricator.kde.org/D21198
Comment 4 Matthieu Gallien 2019-05-14 05:25:47 UTC
Git commit c4c06554076bd4839a2f9ee925731bc5459bc55c by Matthieu Gallien.
Committed on 14/05/2019 at 05:25.
Pushed by mgallien into branch '0.4'.

compute correct sizes when using TextMetrics

Summary:
Use boundingRect of TextMetrics to compute the correct sizes

ensure all font.pointSize are set to integer values

Test Plan: Everything is looking fine

Reviewers: #elisa, ngraham

Reviewed By: ngraham

Differential Revision: https://phabricator.kde.org/D21198

M  +1    -7    src/qml/BaseTheme.qml
M  +3    -3    src/qml/BasicPlayListAlbumHeader.qml
M  +5    -9    src/qml/ContextView.qml
M  +3    -2    src/qml/FileBrowserDelegate.qml
M  +3    -1    src/qml/GridBrowserDelegate.qml
M  +3    -1    src/qml/GridBrowserView.qml
M  +0    -10   src/qml/MediaPlayListView.qml
M  +2    -2    src/qml/MediaPlayerControl.qml
M  +0    -6    src/qml/MediaTrackDelegate.qml
M  +2    -1    src/qml/MetaDataDelegate.qml
M  +2    -16   src/qml/NavigationActionBar.qml
M  +18   -18   src/qml/PlayListEntry.qml
M  +29   -23   src/qml/SimplePlayListEntry.qml
M  +1    -1    src/qml/TopNotificationItem.qml
M  +1    -1    src/qml/TrackImportNotification.qml
M  +1    -1    src/qml/ViewSelector.qml

https://commits.kde.org/elisa/c4c06554076bd4839a2f9ee925731bc5459bc55c