Bug 407333 - Hardcoded sidebar width causes long strings to get elided
Summary: Hardcoded sidebar width causes long strings to get elided
Status: RESOLVED DUPLICATE of bug 415684
Alias: None
Product: Discover
Classification: Applications
Component: discover (show other bugs)
Version: 5.15.4
Platform: Kubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: Dan Leinir Turthra Jensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-05-08 14:32 UTC by Alexey Ilyin
Modified: 2020-01-13 23:41 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Discover's main window (140.04 KB, image/png)
2019-05-08 14:32 UTC, Alexey Ilyin
Details
works for me for some reason... (107.23 KB, image/png)
2020-01-13 15:06 UTC, Alexander Potashev
Details
other section (223.74 KB, image/png)
2020-01-13 19:23 UTC, Alexey Ilyin
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Ilyin 2019-05-08 14:32:58 UTC
Created attachment 119914 [details]
Discover's main window

SUMMARY
Label of menu item "Application Addons" is cut off in the Russian translation

STEPS TO REPRODUCE
1. Set system language to Russian.
2. Open Discover (ver. 5.15.4)

OBSERVED RESULT
Label of menu item "Application Addons" is cut off.

EXPECTED RESULT
Label of menu item "Application Addons" fits well.

SOFTWARE/OS VERSIONS
Linux: 5.0.0
KDE Plasma Version: 5.15
KDE Frameworks Version: 5.57
Qt Version: 5.12.2
Comment 1 Nate Graham 2019-05-09 15:10:17 UTC
Yeah that's because this sidebar currently has a hardcoded width. It should probably auto-size itself to the longest string in the model (within reason)
Comment 2 Aleix Pol 2019-05-16 12:07:40 UTC
I'm not sure it makes sense to have the width depend on the contents because this will make boot all weird.

How about we allow items there to have two lines? Or maybe we can find other ways to write it so it fits?
Comment 3 Nate Graham 2019-05-17 13:29:46 UTC
Options:
- Reduce font size, padding, or use other ways to allow more text to fit into the same space. Not sure going to multiline strings is a great idea though.
- Talk to the Russian translation team to see if this translation really needs to be so long
- Auto-size the sidebar to fit the longest string in it
- Allow the sidebar width to be manually expanded (within reason)
Comment 4 Aleix Pol 2020-01-13 14:28:10 UTC
Alexander Potashev, I see you're CC'd, what do you think?
Comment 5 Alexander Potashev 2020-01-13 15:06:57 UTC
Created attachment 125089 [details]
works for me for some reason...

It works for me for unknown reason.

My teammate Alexander Yavorsky also has the same problem like reported (the exact same number of charaters are truncated).

We can reduce the string by 2 characters by taking out the preposition from the middle of the string - that should be enough, will test later.
Comment 6 Alexey Ilyin 2020-01-13 19:23:18 UTC
Created attachment 125100 [details]
other section

I see that the problem is not only in this particular item. All sections have items with elided labels...

I think that double(multi)-line labels would solve this problem, otherwise it makes no sense to have labels that will never be fully visible.
Comment 7 Nate Graham 2020-01-13 22:17:17 UTC
That could work, since these list items are tall enough to accommodate two-line strings.

I still think this is basically a Kirigami issue though. We may override the width in Discover, but the size is hardcoded in Kirigami.
Comment 8 postix 2020-01-13 22:54:05 UTC
Isn't this issue related to #415684 ?(In reply to Nate Graham from comment #7)

> I still think this is basically a Kirigami issue though. We may override the
> width in Discover, but the size is hardcoded in Kirigami.

Isn't this issue somehow related to #415684 ?
Comment 9 Nate Graham 2020-01-13 23:41:04 UTC
Ah yes, that's the one.

Let's track this in Kirigami for sanity's sake.

*** This bug has been marked as a duplicate of bug 415684 ***