Bug 407280 - Skrooge flatpak unintentionally builds unused tests
Summary: Skrooge flatpak unintentionally builds unused tests
Status: RESOLVED FIXED
Alias: None
Product: skrooge
Classification: Applications
Component: general (show other bugs)
Version: Trunk from git
Platform: Flatpak Linux
: NOR minor
Target Milestone: 25.1.0
Assignee: Stephane MANKOWSKI
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-05-07 00:41 UTC by skierpage
Modified: 2019-05-07 21:34 UTC (History)
1 user (show)

See Also:
Latest Commit: https://invent.kde.org/kde/flatpak-kde-applications/commit/a3712bb15f185f855346c27c73201c1a42c00688
Version Fixed In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description skierpage 2019-05-07 00:41:41 UTC 
Looking at the latest Skrooge flatpak build log https://binary-factory.kde.org/job/Skrooge_flatpak/13/consoleFull
it seems to build all skrooge tests. But I don't think it runs them and they aren't installed in the flatpak.

The log has the warning:

  09:34:52    Manually-specified variables were not used by the project:
  09:34:52  
  09:34:52      ENABLE_TESTING

and https://cgit.kde.org/flatpak-kde-applications.git/tree/org.kde.skrooge.json#n86 has:
         "config-opts":[
            "-DQT4_BUILD=OFF",
            "-DQCA_SUFFIX=qt5",
            "-DENABLE_TESTING=OFF",

but looking at Skrooge's CMakeLists.txt line 23:
  OPTION(SKG_BUILD_TEST "Build the test" ON)

perhaps that line in org.kde.skrooge.json should be
            "-DSKG_BUILD_TEST=OFF",
Comment 1 Stephane MANKOWSKI 2019-05-07 21:34:04 UTC 
Git commit a3712bb15f185f855346c27c73201c1a42c00688 by Stephane MANKOWSKI.
Committed on 07/05/2019 at 21:33.
Pushed by smankowski into branch 'master'.

Skrooge flatpak unintentionally builds unused tests
Skrooge flatpak needs later libofx
Related: bug 407279

M  +4    -2    org.kde.skrooge.json

https://invent.kde.org/kde/flatpak-kde-applications/commit/a3712bb15f185f855346c27c73201c1a42c00688