Bug 406993 - GHNS window: buttons are resized when you start to type a search term
Summary: GHNS window: buttons are resized when you start to type a search term
Status: RESOLVED WORKSFORME
Alias: None
Product: frameworks-knewstuff
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: 5.57.0
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: Alexander Lohnau
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-04-27 22:07 UTC by Patrick Silva
Modified: 2020-10-14 16:06 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.73
Sentry Crash Report:


Attachments
screen recording (209.01 KB, video/webm)
2019-04-27 22:07 UTC, Patrick Silva
Details
new screen recording (510.81 KB, video/webm)
2020-08-01 12:19 UTC, Patrick Silva
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2019-04-27 22:07:07 UTC
Created attachment 119680 [details]
screen recording

SUMMARY
As we can see in attached screen recording, the buttons above "Order by:" are resized when you start to type a search term. Such behavior affects all GHNS windows on my system.

STEPS TO REPRODUCE
1. open system settings > Icons
2. click "Get new icons..." button
3. start to type any search term

OBSERVED RESULT
Watch the attached screen recording please.

EXPECTED RESULT
no button is resized

SOFTWARE/OS VERSIONS
Operating System: Arch Linux 
KDE Plasma Version: 5.15.4
KDE Frameworks Version: 5.57.0
Qt Version: 5.12.3
Comment 1 Nate Graham 2019-04-30 15:36:13 UTC
It looks like the text field's clear button appearing provokes the size change.
Comment 2 Patrick Silva 2019-05-13 17:43:03 UTC
I can't reproduce this behavior anymore.

Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.15.80
KDE Frameworks Version: 5.58.0
Qt Version: 5.12.0
Comment 3 Nate Graham 2019-05-13 18:07:07 UTC
Me neither. Possibly fixed by the horizontal scrollbar sizing bug fix.
Comment 4 Patrick Silva 2019-08-02 17:29:35 UTC
This behavior is reroducible again.

Operating System: Arch Linux 
KDE Plasma Version: 5.16.4
KDE Frameworks Version: 5.60.0
Qt Version: 5.13
Comment 5 Bug Janitor Service 2020-07-22 09:32:42 UTC
A possibly relevant merge request was started @ https://invent.kde.org/frameworks/knewstuff/-/merge_requests/16
Comment 6 Alexander Lohnau 2020-07-22 13:59:23 UTC
Git commit 91e46e975fa52ecde1fa0bc54e678c1bdeea8ae8 by Alexander Lohnau.
Committed on 22/07/2020 at 09:32.
Pushed by alex into branch 'master'.

Fix moving buttons when seach text is inserted
FIXED-IN: 5.73

By setting a maximum width we can be sure that the layout does not move when
the clear button gets shown.
Also the placeholder text gets changes to "Search ...", because
the old text can't be fully displayed.

M  +8    -2    src/downloadwidget.ui

https://invent.kde.org/frameworks/knewstuff/commit/91e46e975fa52ecde1fa0bc54e678c1bdeea8ae8
Comment 7 Patrick Silva 2020-08-01 12:19:19 UTC
Created attachment 130551 [details]
new screen recording

This bug is less noticeable after your patch, but it persists.

Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.19.80
KDE Frameworks Version: 5.73.0
Qt Version: 5.14.2
Comment 8 Patrick Silva 2020-08-08 13:41:30 UTC
humm, surprisingly I can't reproduce on Arch Linux after update to frameworks 5.73, then I noticed that this behavior is related to font used. On Arch I use Roboto and on affected neon unstable I use Liberation Sans. I changed to default font settings and this behavior is no longer reproducible on neon unstable too.
Comment 9 Alexander Lohnau 2020-10-06 07:52:43 UTC
Hmm, this is a really nische bug and it now only affects users who changed the fontconfig. Would you mind marking this bug as resolved? In general the QWidgets dialog is more or less on life support.
Comment 10 Patrick Silva 2020-10-14 15:00:30 UTC
I think that this issue should not be reproducible with any font settings.
But you can close this report if you want. :)
Comment 11 Nate Graham 2020-10-14 16:06:13 UTC
OK. :)