Bug 406914 - Currently-active item in new grid-style KCMs not indicated as such when another item is selected
Summary: Currently-active item in new grid-style KCMs not indicated as such when anoth...
Status: RESOLVED FIXED
Alias: None
Product: frameworks-kdeclarative
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR minor
Target Milestone: ---
Assignee: Marco Martin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-04-26 08:44 UTC by Murz
Modified: 2021-01-25 22:49 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.79


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Murz 2019-04-26 08:44:14 UTC
In KDE System Settings 'Choose the Plasma theme' window we can quickly change current active theme to other via "Apply" button. But we can't see which theme from list is active now - all themes in list looks same, and I can't see any highlights for current active theme.

Please add some highlight for visually differ current active theme in list of themes. Additionally, will be good to have separate text line with "Current theme: <theme name>" in some place of window, eg at left of "Install from file" area.
Comment 1 Kai Uwe Broulik 2019-04-26 09:02:07 UTC
Can you make a screenshot, please also specify your Plasma and KDE Frameworks version. You can find them in kinfocenter. Here on 5.15.4 the active Plasma theme has a thick blue frame.
Comment 2 Murz 2019-04-26 09:15:28 UTC
When I open list, current theme is active and have thick blue frame. But when I click on other theme (without applying), blue frame goes to it, so I can't see which theme is applied now. Plasma is 5.15.4.

Here is screenshot: https://i.imgur.com/eqeHhTW.png - I have activated "Lietukas theme", that was be framed when I open window, but I do single click on "Breeze Dark" and forgot which theme is active (applied) now.
Comment 3 Kai Uwe Broulik 2019-04-26 09:19:30 UTC
Ah. Well, that's how lists work everywhere. You click somewhere else, it highlights there instead, you hit Apply.
Comment 4 Kai Uwe Broulik 2019-04-26 09:19:55 UTC
Could be an interesting approach to slightly highlight the current setting, indeed.
Comment 5 Bug Janitor Service 2020-07-28 18:28:21 UTC
A possibly relevant merge request was started @ https://invent.kde.org/frameworks/kdeclarative/-/merge_requests/7
Comment 6 Nate Graham 2021-01-25 22:49:44 UTC
Git commit d142323fb24ef6cc324fd9917610956606a946aa by Nate Graham.
Committed on 22/01/2021 at 16:51.
Pushed by ngraham into branch 'master'.

Disambiguate selected vs hovered states for GridDelegate

Right now the GridDelegate component uses nearly the same visual style
for both its hovered and selected states (a blue ring drawn around the
grid item), with the only difference being a slight lightening effect
for the hovered item. This effect is often practically invisible,
especially with a light color scheme.

This commit matches the semantics of list items and uses a lighter color
for the hovered state compared to the highlighted state.

In addition, the selected item now uses bold text, which is a convention
we use in other places too.
FIXED-IN: 5.79

M  +9    -1    src/qmlcontrols/kcmcontrols/qml/GridDelegate.qml

https://invent.kde.org/frameworks/kdeclarative/commit/d142323fb24ef6cc324fd9917610956606a946aa