Bug 406700 - Color profile in New image dialog switches to default when trying to set up bit depth
Summary: Color profile in New image dialog switches to default when trying to set up b...
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Usability (show other bugs)
Version: nightly build (please specify the git hash!)
Platform: Microsoft Windows Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: Tiar
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-04-20 10:40 UTC by Tiar
Modified: 2019-07-08 14:59 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tiar 2019-04-20 10:40:16 UTC
SUMMARY
Color profile switches to default when trying to set up bit depth of the color space.

STEPS TO REPRODUCE
1. Go to File->New dialog.
2. Set a color profile you'll recognize later. Cannot be the default one.
3. Set a different bit depth.

OBSERVED RESULT
Set up color profile switches back to default.

EXPECTED RESULT
Set up color space stays the same.



NOTES:
It is most probably caused by dynamic setting of default color space according to the color model you want to use (CMYK has different profiles than RGB).



SOFTWARE/OS VERSIONS
Version: 4.2.0-pre-alpha (git fb08951)
Windows: 10
Qt Version: 5.12.2
Comment 1 Tiar 2019-07-08 11:53:43 UTC
Git commit 9ebd13b4cbc9ebf25e544793439e908e725f84bc by Agata Cacko.
Committed on 08/07/2019 at 11:39.
Pushed by tymond into branch 'master'.

Fix switching profile to default in New file dialog

Before this commit if you first selected the color model,
then color profile, then color depth, the color profile would switch to
default for this color depth no matter that the user just set it
manually. This is mostly the problem if someone is for example using
Rec2020 profile for HDR images and switches between 32 and 16 bit
color depths.

Behaviour now:
- by default color profile changes to the default one that suits
the color model and color depth
- if the user sets the profile manually, it is remembered
and if it changes color depth, the profile doesn't change
(keep in mind that "(Default)" suffix is still attached
to the default profile, so it's easy to find in case the user wants it
- if the user changes the color model, the default behaviour
(switching profile automatically) is restored until the user
sets up the profile maually again.

M  +40   -7    libs/ui/widgets/kis_color_space_selector.cc
M  +4    -0    libs/ui/widgets/kis_color_space_selector.h

https://invent.kde.org/kde/krita/commit/9ebd13b4cbc9ebf25e544793439e908e725f84bc
Comment 2 Halla Rempt 2019-07-08 14:59:29 UTC
Git commit e45b318667de1f887668efedf32166f3a126a198 by Boudewijn Rempt, on behalf of Agata Cacko.
Committed on 08/07/2019 at 14:59.
Pushed by rempt into branch 'krita/4.2'.

Fix switching profile to default in New file dialog

Before this commit if you first selected the color model,
then color profile, then color depth, the color profile would switch to
default for this color depth no matter that the user just set it
manually. This is mostly the problem if someone is for example using
Rec2020 profile for HDR images and switches between 32 and 16 bit
color depths.

Behaviour now:
- by default color profile changes to the default one that suits
the color model and color depth
- if the user sets the profile manually, it is remembered
and if it changes color depth, the profile doesn't change
(keep in mind that "(Default)" suffix is still attached
to the default profile, so it's easy to find in case the user wants it
- if the user changes the color model, the default behaviour
(switching profile automatically) is restored until the user
sets up the profile maually again.

M  +40   -7    libs/ui/widgets/kis_color_space_selector.cc
M  +4    -0    libs/ui/widgets/kis_color_space_selector.h

https://invent.kde.org/kde/krita/commit/e45b318667de1f887668efedf32166f3a126a198