Bug 406679 - joystick icon looks a black ball
Summary: joystick icon looks a black ball
Status: RESOLVED FIXED
Alias: None
Product: Breeze
Classification: Plasma
Component: Icons (show other bugs)
Version: 5.15.4
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: visual-design
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-04-19 13:52 UTC by Patrick Silva
Modified: 2019-06-20 10:33 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.60


Attachments
screenshot (17.49 KB, image/png)
2019-04-19 13:52 UTC, Patrick Silva
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2019-04-19 13:52:00 UTC
Created attachment 119503 [details]
screenshot

SUMMARY
As we can see in attached screenshot, joystick icon has no similarity with a joystick, it looks a black ball.

STEPS TO REPRODUCE
1. open system settings > input devices and observe the icon of "Joystick" section
2. 
3. 

EXPECTED RESULT
joystick icon looks a... joystick

SOFTWARE/OS VERSIONS
Operating System: Arch Linux 
KDE Plasma Version: 5.15.4
KDE Frameworks Version: 5.57.0
Qt Version: 5.12.2
Comment 1 Nate Graham 2019-04-19 14:32:11 UTC
Yeah, it kind of does.
Comment 2 Nate Graham 2019-04-21 18:14:42 UTC
There are multiple problems here:
- the Joystick KCM uses the icon `preferences-desktop-gaming` which is semantically incorrect (The KCM is about configuring the joystick input device, not gaming in general)
- The preferences-desktop-gaming icon depicts the two-dimensional D-pad from a gaming controller, rather than a generic gaming-related icon like input-gaming
- We have no icon that actually shows a joystick

I think the solution is to:
1. Create a new icon `input-joystick` that actually looks like a joystick
2. Make a symlink called `preferences-desktop-joystick` that points to it
3. Have the joystick KCM use that icon,
4.Make `preferences-desktop-gaming` a symlink to `input-gaming`, and keep that in our back pocket for if we ever have generic gaming-related KCM.
Comment 3 Noah Davis 2019-06-20 10:33:58 UTC
Git commit 7ef3c35c7ed69a507f25a6cb8cd92fbb223756a7 by Noah Davis.
Committed on 20/06/2019 at 10:33.
Pushed by ndavis into branch 'master'.

Change joystick settings icon to game controller

Summary:
Most of the "joysticks" that people have are game controllers, so a complete controller is better than just a D-pad.
FIXED-IN: 5.60

Test Plan:
left: old, right: new
{F6917203, size=full}

Reviewers: #vdg, ngraham

Reviewed By: #vdg, ngraham

Subscribers: usta, davidedmundson, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D21919

T  +1    -64   icons-dark/preferences/32/preferences-desktop-gaming.svg
T  +1    -64   icons/preferences/32/preferences-desktop-gaming.svg

https://commits.kde.org/breeze-icons/7ef3c35c7ed69a507f25a6cb8cd92fbb223756a7