Bug 406661 - Display of tab icons no longer works
Summary: Display of tab icons no longer works
Status: RESOLVED WORKSFORME
Alias: None
Product: konsole
Classification: Applications
Component: tabbar (show other bugs)
Version: 19.04.0
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Konsole Developer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-04-18 17:59 UTC by shevegen
Modified: 2020-12-03 04:34 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
attachment-22027-0.html (1020 bytes, text/html)
2019-04-23 16:14 UTC, tcanabrava
Details

Note You need to log in before you can comment on or make changes to this bug.
Description shevegen 2019-04-18 17:59:59 UTC
I am not sure if I have found a bug/regression or not.

So here is the behaviour:

In KDE konsole 18.12.3 when I send this to a tab:

\e]32;utilities-terminal\a

I get the terminal-icon that appears to be the default,
on the left hand side of the tab at hand.

IF I do the very same on KDE konsole 19.04.0, no permanent
change appears to happen. Something appears to flicker but
then seems to be instantly reset.

The net result is that on konsole 19.04.0 I am not able to
change the icon, whereas on konsole 18.12.3.

I do not know if this is a bug or not or some side effect.
Although I think IF this is indeed how I describe, then I
think this is a bug; or a regression. IF it is a deliberate
change, it may be useful to mention it in the official 
announcement, and suggest to users how to change or what
to change in order to be able to change the icon.

I should perhaps also explain how I found out:

- I noticed that each tab now has a close button and I wanted
to try this out. I tried it out and realized that I do not
like this functionality because it occupies too much space
per tab (I use a custom .css file for the kde konsole tabs,
to visually distinguish between active tabs and inactive tabs,
and I use lots of icons for different kde konsole tabs, via
some ruby script. I then looked at editing kde konsole settings
and there is, thankfully, a setting that allows us to disable
the close button per tab. I did this, and then I tried to 
use another icon on the kde konsole tab and it did not work.
Not sure if this is just me or whether this is indeed a bug,
but I can guarantee to 100% that this behaviour works on 
18.x 100%. It does not seem to work on 19.x, at the least not
with my testing so far - didn't test it for long evidently since
the kde application release is out since only a few hours or so
at best.
Comment 1 Kurt Hindenburg 2019-04-19 00:33:14 UTC
The "default" terminal icon is no longer displayed on tabs - if you custon a profile's icon, it will be displayed.

See the discussion on https://phabricator.kde.org/D17747

Why are you using "\e]32;utilities-terminal\a" instead of just changing the profile's icon?  I don't think we thought of that when making this change.
Comment 2 Kurt Hindenburg 2019-04-21 20:41:07 UTC
Yea, 32 does not work now in 19.04/master.

change icon via \033]32;Icon\007
Comment 3 Kurt Hindenburg 2019-04-21 21:40:15 UTC
Actually it works here on 19.04; the big change in splitview broke it in master.
Comment 4 tcanabrava 2019-04-23 16:14:54 UTC
Created attachment 119594 [details]
attachment-22027-0.html

Hm.

Em ter, 23 de abr de 2019 às 16:48, Nate Graham <bugzilla_noreply@kde.org>
escreveu:

> https://bugs.kde.org/show_bug.cgi?id=406661
>
> Nate Graham <nate@kde.org> changed:
>
>            What    |Removed                     |Added
>
> ----------------------------------------------------------------------------
>                  CC|                            |nate@kde.org
>
> --
> You are receiving this mail because:
> You are the assignee for the bug.
Comment 5 Justin Zobel 2020-11-03 03:49:30 UTC
Can you please confirm the merge of D17747 solved the issue around custom icons, thanks.
Comment 6 Bug Janitor Service 2020-11-18 04:33:52 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 7 Bug Janitor Service 2020-12-03 04:34:08 UTC
This bug has been in NEEDSINFO status with no change for at least
30 days. The bug is now closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!