Bug 406646 - Page background color changing feature should affect large solid-fill objects with the background's color as well, not just the background itself
Summary: Page background color changing feature should affect large solid-fill objects...
Status: CONFIRMED
Alias: None
Product: okular
Classification: Applications
Component: PDF backend (show other bugs)
Version: 1.6.3
Platform: Ubuntu Linux
: NOR wishlist
Target Milestone: ---
Assignee: Okular developers
URL:
Keywords:
: 418255 (view as bug list)
Depends on:
Blocks:
 
Reported: 2019-04-18 02:01 UTC by widon1104
Modified: 2020-03-19 14:02 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Can not really change page color (304.71 KB, image/png)
2019-04-18 02:01 UTC, widon1104
Details
the pdf file (1.92 MB, application/pdf)
2019-04-18 06:55 UTC, widon1104
Details
win10 adobe reader success change backgroud color (127.72 KB, image/png)
2019-04-19 01:40 UTC, widon1104
Details

Note You need to log in before you can comment on or make changes to this bug.
Description widon1104 2019-04-18 02:01:05 UTC
Created attachment 119477 [details]
Can not really change page color

SUMMARY
I want to change the page color to light yellow to relieve eye fatigue, but I find out the page color do not really change.
In attached file, I change the page color to green, but only left and right side change the color to green, the part has words do not change at all.
This behavior make 'change page color' useless I think.

If I choose 'reverse color' the whole backgroud change and the words color become white. so I think 'change page color' is practicable.

STEPS TO REPRODUCE
1. Configure Okular->Accessibility->Change colors->Change page color
2. Choose a color you like

OBSERVED RESULT
The page color do not really change, important part of the page's color do not change.

EXPECTED RESULT
whole page color change to color I set

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
Comment 1 Michael Weghorn 2019-04-18 06:48:35 UTC
(In reply to widon1104 from comment #0)
> In attached file, I change the page color to green, but only left and right
> side change the color to green, the part has words do not change at all.

Can you please attach the actual file that you have opened in Okular in addition (attachment shows the screenshot)?
Comment 2 widon1104 2019-04-18 06:55:18 UTC
Created attachment 119479 [details]
the pdf file

The pdf file attached.
Comment 3 Michael Weghorn 2019-04-18 07:16:10 UTC
Thanks.
Comment 4 Albert Astals Cid 2019-04-18 21:34:54 UTC
It does change the paper color, you can clearly see the paper color is now blue https://i.imgur.com/7jEXLiu.png

What we can't change is the fact that there's a big white rectangle as part of the page contents.
Comment 5 widon1104 2019-04-19 01:40:50 UTC
Created attachment 119493 [details]
win10 adobe reader success change backgroud color

I use win10 adobe reader success change the same document background color to green.

Please do not close this bug so quickly.
Comment 6 widon1104 2019-04-19 02:48:42 UTC
Finally I find out a software support linux called foxit which can change background color successfully.
You can download foxit reader in: https://www.foxitsoftware.com/pdf-reader/
After install this software you can use Edit->preference->General->Page Background to change the background color to the document I upload

foxit reader satisfy my need, but this software no longger update for a long time.

I still hope okular can fix this bug.
Comment 7 widon1104 2019-04-19 08:13:29 UTC
This is a bug does not fix yet.
Comment 8 Albert Astals Cid 2019-04-20 09:59:00 UTC
It's not a bug, if it makes you happy this is open, let's just leave it open
Comment 9 widon1104 2019-04-20 10:12:03 UTC
Do you try foxit reader ? This software change backgroud color perfectly without a lot of restriction.

Okular change background color function with a lot of restriction makes this feature almost useless.

This bug already exist for many years.

I will not happy If this bug do not fix.
Comment 10 Albert Astals Cid 2019-04-20 10:16:10 UTC
(In reply to widon1104 from comment #9)
> Do you try foxit reader ? This software change backgroud color perfectly
> without a lot of restriction.

No, i try not to use non Free software if i don't have to. This is one of the cases when i don't have to.

> Okular change background color function with a lot of restriction makes this
> feature almost useless.
> 
> This bug already exist for many years.

It's not a bug.

> I will not happy If this bug do not fix.

I am not responsible for your happiness. Only you are.
Comment 11 widon1104 2019-04-20 10:24:11 UTC
Try to learn from non Free software will make free software better.
Comment 12 Nate Graham 2019-04-20 13:02:52 UTC
Albert, I think I understand that it's the PDF file authior's fault for adding an opaque white square on top of the background, but it would be nice of Okular could detect this type of thing and handle is so that the background changing effect works more reliably.

To the user, the background is the background. Whether there's an unnecessary white square on top of it is irrelevant; from the user's perspective, the color changing feature does not work with this PDF.

I think it's a fairly reasonable request since the user shouldn't have to understand the structure of the PDF file itself, nor should the feature only work with perfectly-structured PDFs.

Changing the title to reflect the technical change needed to implement this feature request.
Comment 13 widon1104 2020-02-20 06:20:40 UTC
I agree with Nate Graham.
No body fix this bug until now?
Comment 14 Christoph Feck 2020-03-19 14:02:26 UTC
*** Bug 418255 has been marked as a duplicate of this bug. ***