Bug 406593 - Usability issue: destructive titlebar actions
Summary: Usability issue: destructive titlebar actions
Status: RESOLVED INTENTIONAL
Alias: None
Product: kwin
Classification: Plasma
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: KWin default assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-04-16 10:52 UTC by plane.wander
Modified: 2019-04-17 18:11 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:
plane.wander: Usability+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description plane.wander 2019-04-16 10:52:37 UTC
In the "Window Actions and Behavior" dialog in the "Titlebar Actions" tab the action "Close" can be assigned to many actions, which can lead to data loss. For example an admin could have changed the default behavior to "Close" but the users using the computer are unfamilar with that, then they can easily lose data just by clicking the title bar. It can be reproduced easily, for example:

1. change the left button action in the titlebar from "Raise"/"Activate & Raise" to "Close"
2. click at the titlebar of a window with the left mouse button

OBSERVED RESULT
The window closes.

EXPECTED RESULT
The window shouldn't close.

Either the action "Close" should be removed from those events to fix this or the actions shouldn't be configurable at all. Of course I'll gladly provide additional information or patches if needed.
Comment 1 Vlad Zahorodnii 2019-04-16 12:22:08 UTC
(In reply to plane.wander from comment #0)
> loss. For example an admin could have changed the default behavior to
> "Close" but the users using the computer are unfamilar with that, then they
> can easily lose data just by clicking the title bar.
Then this admin should be fired I guess.

I see nothing wrong with this action. It's not enabled by default.
Comment 2 plane.wander 2019-04-16 12:40:35 UTC
(In reply to Vlad Zagorodniy from comment #1)
> Then this admin should be fired I guess.

Ok, but then I'm confused. The window present effect had a similar feature: Middle click on a window to close it. This feature was also not enabled by default but it was removed from KWin for the same reason I gave: What if an admin enables it and its users don't know about it, or what if a friend of yours is using your computer and doesn't know that you enabled it -> This can cause data loss for the users and therefore must be removed.

So where is the difference between this feature and the "middle click to close" in the window present effect?

> I see nothing wrong with this action. It's not enabled by default.

So was the middle click to close feature in the window present effect.
Comment 3 Vlad Zahorodnii 2019-04-16 14:42:12 UTC
If it were a real issue, then there would be lots of bug reports asking to remove destructive actions.

I'm sorry but what you're asking won't be implemented. So, stop wasting your and our time.
Comment 4 plane.wander 2019-04-16 15:07:11 UTC
(In reply to Vlad Zagorodniy from comment #3)
> If it were a real issue, then there would be lots of bug reports asking to
> remove destructive actions.

There also wasn't a single bug report asking to remove the same destructive actions from the present windows effect, yet it was removed proactively. I just want to do the same here, so KWin is behaving in a consistent way. Or, if it is considered ok to have this sort of destructive actions available when disabled by default I'm also willing to add the feature back to the present windows effect.

> I'm sorry but what you're asking won't be implemented. So, stop wasting your
> and our time.

So it's ok if I submit a patch to add the same functionality back to the present windows effect, because the reasons to remove it in the first place aren't considered valid any more? I mean it has to be one or the other: Either it's bad to have this sort of destructive actions to close windows or it's fine as long as they are disabled by default.
Comment 5 Nate Graham 2019-04-17 18:11:46 UTC
(In reply to plane.wander from comment #4)
> So it's ok if I submit a patch to add the same functionality back to the
> present windows effect, because the reasons to remove it in the first place
> aren't considered valid any more? I mean it has to be one or the other:
> Either it's bad to have this sort of destructive actions to close windows or
> it's fine as long as they are disabled by default.
FWIW, I would support this, for just the reasoning you give. Makes sense to me, can't have it both ways.