Created attachment 119428 [details] Drag and drop the tag, and choose "Merge" SUMMARY I have lots of people in my collection, whose tags sometimes are within "People", sometimes outside, and sometimes in both places. When dragging a Tag inside "People" and move it outside (as a first-level tag in the hierarchy), it warns me that there's already one tag with that name (correct) and whether I want to merge them, if I click "yes", I get an error message saying "No such album". See attachments. Dragging the tag right over it's duplicated and and choosing "merge" works properly though. STEPS TO REPRODUCE 1. Drag an tag to a higher level position, where another tag is already called the same. 2. When prompted to merge, say yes. OBSERVED RESULT Error message: "No such album" EXPECTED RESULT Merge should be successful. SOFTWARE/OS VERSIONS Ubuntu 18.04 with GNOME digikam-6.1.0-git-20190404T203330-qtwebkit-x86-64.appimage
Created attachment 119429 [details] "No such album" error message.
Note: it only happens when dragging a tag to a higher level. Dragging a first-level tag to a tag that contains the same name works properly. (sorry, it's complicated to describe)
Git commit f5ccd16345faffbab9e91dc1f65ee321abb08efa by Maik Qualmann. Committed on 16/04/2019 at 05:54. Pushed by mqualmann into branch 'master'. fix no such TAlbum error FIXED-IN: 6.2.0 M +2 -1 NEWS M +8 -2 core/libs/album/manager/albummanager_talbum.cpp https://commits.kde.org/digikam/f5ccd16345faffbab9e91dc1f65ee321abb08efa
Thanks, it works now. However, there's a little inconvenience now. If you drag and drop several tags, and more than one finds an identical tag in the higher-level tag, it asks for each one of them whether you want to merge them or not (maybe it just needs to ask once?, or for each tag, but indicating which tag is it?), and then, when you say yes, it complains that another process is currently being carried out (digikam still didn't finish writing the changes to the previous tag). I think it should wait for the previous tag to be complete and then automatically continue with the following tag. Do you want me to open a bug for this?
Right, we check if a process is already running and that is correct (Bugreport). Just wait a little bit and look to the Progress manager in the status bar. We need to do the database operation immediately and can not buffer it. Otherwise, the tags tree would not be in the consentent state. It definitely can not be solved differently. Or you write your tags later with the Maintenance tool in the images. Maik
I understand, that makes sense, but can't this operation be done automatically? Queue the changes, check if a process is still in operation, and when it's finished, do the next group of tags.
And then? The operation is on hold. Tags tree still shows the old stand and you try to move the next tags. Maybe within the last tags group. How should such a nesting be solved? Besides, it may also affect the tag path of the current write operation again. With a file manager, you also have to wait until all the files have been copied and you can not already start to rename or move the directories. Maik
I am not sure I follow what you mean. Imagine the following structure: --Person1 --Person2 --People ----Person1 ----Person2 ----Person3 ----Person4 And you select People/Person1 and People/Person2 and drop them outside "People". It will detect the already existing Person1 and Person2 tags, and ask whether to merge Person1 and then, immediately, Person2. When digikam asks for the merging of Person2, the merging of Person1 is still pending (you can see the progress bar at the bottom doing its stuff), so it cannot be done, and it obviously complains about that. What I mean (sorry if that's what you already explained), is that the merge of Person2 could maybe be put on hold until the progress from Person1 is done, delaying the apparition of the Person2 merge dialog. I don't know if there's internally a way to detect when a process is taking place.